UI Code Quality: Finish porting outliner tree building to C++
ClosedPublic
Actions

Authored by Nathan Craddock (natecraddock) on Dec 3 2020, 7:05 PM.

Details

Reviewers

Commits

rB887a60244828: Cleanup: Finish porting outliner tree building to C++
rB48acf15f9856: Cleanup: Outliner Data API display mode
rBaaa02984d397: Cleanup: Outliner scenes display mode
rB1db40c29e5f3: Cleanup: Outliner orphan data display mode
rB1cc0a59be66a: Cleanup: Outliner video sequencer display mode

Summary

This is a follow-up of D9499 which moves each remaining outliner tree display to subclasses of AbstractTreeDisplay.
The display modes classes in this patch are:

Video Sequencer: TreeDisplaySequencer
Orphan Data: TreeDisplayOrphanedData
Scenes: TreeDisplayScenes
Data API: TreeDisplayData

Some small cleanup is also done in outliner_tree.c now that all tree building code is in C++.

Diff Detail

Repository: rB Blender

Event Timeline

Nathan Craddock (natecraddock) requested review of this revision.Dec 3 2020, 7:05 PM

Nathan Craddock (natecraddock) created this revision.

Harbormaster completed remote builds in B11551: Diff 31581.Dec 3 2020, 7:05 PM

Nathan Craddock (natecraddock) added a project: User Interface.Dec 3 2020, 7:06 PM

I recall a discussion a few weeks back about renaming "Orphan Data" to "Orphaned Data" so I did that in the code here.
The name of TreeDisplayData isn't the best, maybe TreeDisplayBlenderData or TreeDisplayDataAPI would be better.

Scrolling over this quickly, looks good!

I think we should follow the internal names, so TreeDisplayIDOrphans and TreeDisplayDataAPI.

This revision is now accepted and ready to land.Dec 4 2020, 5:22 PM

Thanks! I'll change the names before committing then.

Closed by commit rB1cc0a59be66a: Cleanup: Outliner video sequencer display mode (authored by Nathan Craddock (natecraddock)). · Explain WhyDec 5 2020, 2:00 AM

This revision was automatically updated to reflect the committed changes.

Nathan Craddock (natecraddock) added a commit: rB1cc0a59be66a: Cleanup: Outliner video sequencer display mode.

Nathan Craddock (natecraddock) added a commit: rB1db40c29e5f3: Cleanup: Outliner orphan data display mode.

Nathan Craddock (natecraddock) added a commit: rBaaa02984d397: Cleanup: Outliner scenes display mode.

Nathan Craddock (natecraddock) added a commit: rB48acf15f9856: Cleanup: Outliner Data API display mode.

Nathan Craddock (natecraddock) added a commit: rB887a60244828: Cleanup: Finish porting outliner tree building to C++.