Page MenuHome
Differential D9747

Sapling Tree Gen: Use type annotation instead of assignment
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Dec 4 2020, 2:02 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Maniphest Tasks
T83386: Creating trees with leaves in Sapling Tree Gen add-on results in TypeError: can't multiply sequence by non-int of type 'float'
Commits
rBA8c87cf0afccb: Fix T83386: Use type annotation instead of assignment
Summary

This is a fix for T83386. The add-on previously assigned the FloatProperty to bend. This caused accessing bend in calculations to return a reference to the FloatProperty instead of its value. This patch replaced the assignment with an annotation. This is the correct usage since the Python API changes for Blender 2.80.

NOTE: The add-on currently has another problem T83360 which prevent it from working. For the implementation of the patch I had to comment out the usages of props.leafDupliObj.

Diff Detail

Event Timeline

Robert Guetzkow (rjg) created this revision.Dec 4 2020, 2:02 PM
Harbormaster completed remote builds in B11564: Diff 31606.Dec 4 2020, 2:02 PM
Robert Guetzkow (rjg) requested review of this revision.Dec 4 2020, 2:02 PM
Robert Guetzkow (rjg) added a task: T82899: Check operators for potentially missing "UNDO" in bl_options.Dec 4 2020, 2:03 PM
Robert Guetzkow (rjg) removed a task: T82899: Check operators for potentially missing "UNDO" in bl_options.
Robert Guetzkow (rjg) added a task: T83386: Creating trees with leaves in Sapling Tree Gen add-on results in TypeError: can't multiply sequence by non-int of type 'float'.
Bastien Montagne (mont29) accepted this revision.Dec 4 2020, 2:34 PM
This revision is now accepted and ready to land.Dec 4 2020, 2:34 PM
Closed by commit rBA8c87cf0afccb: Fix T83386: Use type annotation instead of assignment (authored by Robert Guetzkow (rjg)). · Explain WhyDec 5 2020, 9:56 AM
This revision was automatically updated to reflect the committed changes.
Robert Guetzkow (rjg) added a commit: rBA8c87cf0afccb: Fix T83386: Use type annotation instead of assignment.
Kein (Kein) added a subscriber: Kein (Kein).Dec 10 2020, 10:11 AM

Can someone explain the reasoning behind incorrect annotations that dont actually comply well with PEP-526?

https://devtalk.blender.org/t/recommended-type-annotations-in-ops/16575

Robert Guetzkow (rjg) added a comment.EditedDec 10 2020, 10:32 AM

@Kein (Kein) that's a valid question, I would suggest you ask members of the Python module about this, perhaps on blender.chat.

Edit: Further discussion happens in T83626, D8782 (for Blender developers) and the DevTalk thread.

Revision Contents
Changeset List

PathSize
add_curve_sapling/
2 lines

Diff 31606

View Options

add_curve_sapling/__init__.py

Loading...