Cleanup: unified range format, removed default values in tooltips
- The unified range format is used (0.0 to 1.0).
- Removed the mention of default values in tooltips.
Details
Details
- Reviewers
Julian Eisel (Severin) - Group Reviewers
User Interface - Commits
- rBbadbf816b867: UI: Consistent Range Descriptions
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Generally a nice improvement I think.
| source/blender/editors/space_image/image_buttons.c | ||
|---|---|---|
| 1069 ↗ | (On Diff #31683) | This reads odd. It's not a full sentence, but looks like one. |
| source/blender/makesrna/intern/rna_pose.c | ||
| 1555 | Isn't it better to just get rid of the equal sign? "(default is 20)". Although I'm not sure if we should mention the defaults at all. We don't do that usually and there's Reset to Default Value. | |
| 1561 | Same here. | |
| 1577 | Would do: "(higher values means more stability, less reactivity; default is 0.1)" | |
| 1586 | And same here. | |
Comment Actions
Removed the mention of default values.
I won't touch "Hard coded Non-Linear, Gamma:1.7" since it is not clear what is meant here.
Probably codec parameters that can't be changed.
#if 1
uiItemL(col, IFACE_("Hard coded Non-Linear, Gamma:1.7"), ICON_NONE);
#else
uiItemR(col, imfptr, "use_cineon_log", 0, NULL, ICON_NONE);
uiItemR(col, imfptr, "cineon_black", 0, NULL, ICON_NONE);
uiItemR(col, imfptr, "cineon_white", 0, NULL, ICON_NONE);
uiItemR(col, imfptr, "cineon_gamma", 0, NULL, ICON_NONE);
#endifComment Actions
Note that this should either be split up into multiple commits, or the commit title should clarify that it's doing more than changing the range format.
Comment Actions
Looks good.
Will change "are limited to 3 and 4 sided faces" to "are limited to 3 or 4 sided faces".
With "higher values means more stability" the subject "higher values" is plural, which would result in using "mean", rather than "means". But... I would resist using the word "mean" in our case because it is natural to think of mathematical mean when dealing with values. Therefore changing to "higher values produce results with more stability, less reactivity"