Paths

Table of Contentst

Differential D977

Fix T43159: Copying of linked datablocks using relpath leads to invalid paths in new copies.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Jan 8 2015, 4:30 PM.

Tags

None

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)

Commits

rBS95847f6ac7ce: Fix T43159: Copying of linked datablocks using relpath leads to invalid paths…
rB95847f6ac7ce: Fix T43159: Copying of linked datablocks using relpath leads to invalid paths…

Summary

Propper fix reverting most of rB60e70c0c6014e5, which was only partial specific fix.
This code uses generic BKE_id_lib_local_paths() func to handle all possible paths.

Diff Detail

Repository: rB Blender
Branch: lib-names-idcopy-fix

Event Timeline

Bastien Montagne (mont29) updated this revision to Diff 3111.Jan 8 2015, 4:30 PM

Bastien Montagne (mont29) retitled this revision from to Fix T43159: Copying of linked datablocks using relpath leads to invalid paths in new copies..

Bastien Montagne (mont29) added reviewers: Campbell Barton (campbellbarton), Sergey Sharybin (sergey).

Bastien Montagne (mont29) updated this object.

LGTM, only minor suggestions.

source/blender/blenkernel/BKE_text.h
54	In general we'd like to get rid of `G.main` use. so passing `Main` around could be kept. Realize its not always pracitcal. so probably copy functions could take a main arg eventually. just something to keep in mind.
source/blender/blenkernel/intern/action.c
219	Wouldn't bother with the comment here, API name is sensible, think its clear what happens. (function its self can have doc).

Update for landing...

Closed by commit rB95847f6ac7ce: Fix T43159: Copying of linked datablocks using relpath leads to invalid paths… (authored by Bastien Montagne (mont29)). · Explain WhyJan 9 2015, 9:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

2 lines

intern/

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

10 lines

7 lines

5 lines

5 lines

2 lines

5 lines

6 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

19 lines

5 lines

7 lines

Diff 3111

source/blender/blenkernel/BKE_text.h

Loading...

source/blender/blenkernel/intern/action.c

Loading...

source/blender/blenkernel/intern/armature.c

Loading...

source/blender/blenkernel/intern/brush.c

Loading...

source/blender/blenkernel/intern/camera.c

Loading...

source/blender/blenkernel/intern/curve.c

Loading...

source/blender/blenkernel/intern/group.c

Loading...

source/blender/blenkernel/intern/image.c

Loading...

source/blender/blenkernel/intern/key.c

Loading...

source/blender/blenkernel/intern/lamp.c

Loading...

source/blender/blenkernel/intern/lattice.c

Loading...

source/blender/blenkernel/intern/library.c

Loading...

source/blender/blenkernel/intern/linestyle.c

Loading...

source/blender/blenkernel/intern/mask.c

Loading...

source/blender/blenkernel/intern/material.c

Loading...

source/blender/blenkernel/intern/mball.c

Loading...

source/blender/blenkernel/intern/mesh.c

Loading...

source/blender/blenkernel/intern/node.c

Loading...

source/blender/blenkernel/intern/object.c

Loading...

source/blender/blenkernel/intern/particle.c

Loading...

source/blender/blenkernel/intern/speaker.c

Loading...

source/blender/blenkernel/intern/text.c

Loading...

source/blender/blenkernel/intern/texture.c

Loading...

source/blender/blenkernel/intern/world.c

Loading...