Page MenuHome
Differential D9781

UI: Update Clip Tracking menus
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Dec 8 2020, 7:27 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Sebastian Koenig (sebastian_k)
Group Reviewers
Motion Tracking
Commits
rB6c15b702796e: UI: Update Clip Tracking menus
Summary
  • Add operators that previously could only be found in panels
  • Re order menus to match other menus
  • Organize Code
BeforeAfter

Diff Detail

Repository
rB Blender
Branch
clip_ui_update (branched from master)
Build Status
Buildable 12150
Build 12150: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Dec 8 2020, 7:27 AM
Aaron Carlisle (Blendify) created this revision.
Harbormaster completed remote builds in B11609: Diff 31725.Dec 8 2020, 7:27 AM
Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)Dec 8 2020, 7:36 AM
Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)Dec 8 2020, 7:44 AM
Aaron Carlisle (Blendify) added a comment.Dec 8 2020, 7:49 AM

Note, this is a required change to migrate the clip editor to the tool system.

Aaron Carlisle (Blendify) added projects: BF Blender (2.92), Motion Tracking, User Interface.Dec 8 2020, 7:50 AM
Aaron Carlisle (Blendify) added reviewers: User Interface, Motion Tracking.
Aaron Carlisle (Blendify) mentioned this in T83612: UI: Tracking: Migrate to active tools based toolbar.Dec 10 2020, 4:44 AM
Sean Kennedy (hype) added a subscriber: Sean Kennedy (hype).Dec 12 2020, 9:44 PM
Aaron Carlisle (Blendify) added inline comments.Dec 24 2020, 6:22 AM
release/scripts/startup/bl_ui/space_clip.py
1367

Perhaps should be renamed to "Refine"

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Jan 8 2021, 5:40 PM
Sergey Sharybin (sergey) added inline comments.
release/scripts/startup/bl_ui/space_clip.py
1367

Not sure why it needs to be renamed to Refine.
Refine is a separate from Track operator: there is clip.refine_markers and there is clip.track_markers

Aaron Carlisle (Blendify) added inline comments.Jan 8 2021, 6:07 PM
release/scripts/startup/bl_ui/space_clip.py
1367

I think the comment was from an older revision please ignore it now.

Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Jan 11 2021, 11:56 AM
Aaron Carlisle (Blendify) marked an inline comment as done.Jan 12 2021, 2:25 AM
Sergey Sharybin (sergey) accepted this revision.Jan 12 2021, 2:41 PM
Sergey Sharybin (sergey) edited reviewers, added: Sergey Sharybin (sergey), Sebastian Koenig (sebastian_k); removed: User Interface, Motion Tracking.
Sergey Sharybin (sergey) added a subscriber: Sebastian Koenig (sebastian_k).

To me this seems reasonable.

@Sebastian Koenig (sebastian_k), do you want to go through this as well?

Sebastian Koenig (sebastian_k) added a comment.Jan 12 2021, 2:45 PM

Yeah, I guess that is reasonable. Thanks!

Aaron Carlisle (Blendify) added a comment.Jan 12 2021, 6:13 PM

@Sebastian Koenig (sebastian_k) does that mean you approve of the changes?

Sebastian Koenig (sebastian_k) accepted this revision.Jan 12 2021, 6:15 PM
This revision is now accepted and ready to land.Jan 12 2021, 6:15 PM
Sebastian Koenig (sebastian_k) added a comment.Jan 12 2021, 6:16 PM
In D9781#252017, @Aaron Carlisle (Blendify) wrote:

@Sebastian Koenig (sebastian_k) does that mean you approve of the changes?

Yeah. I wasnt aware I need to actually approve (never done that before ;)

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Jan 12 2021, 6:29 PM

Adding more items to the menus here makes sense, and the reordering looks better to me too, I didn't look into the changes in detail though.

Aaron Carlisle (Blendify) updated this revision to Diff 32698.Jan 12 2021, 8:40 PM
  • Merge branch 'master' into clip_ui_update
  • Change solve_camera label based on camera/object tracking
Harbormaster completed remote builds in B12150: Diff 32698.Jan 12 2021, 8:40 PM
Closed by commit rB6c15b702796e: UI: Update Clip Tracking menus (authored by Aaron Carlisle (Blendify)). · Explain WhyJan 12 2021, 8:45 PM
This revision was automatically updated to reflect the committed changes.
Aaron Carlisle (Blendify) added a commit: rB6c15b702796e: UI: Update Clip Tracking menus.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
210 lines

Diff 32698

View Options

release/scripts/startup/bl_ui/space_clip.py

Loading...