Page MenuHome
Differential D9786

Fix T83361: UV Editor does not draw pinned selected UVs as pinned
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 8 2020, 4:11 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Maniphest Tasks
T83361: UV Editor does not draw pinned selected UVs as pinned
Commits
rB04c7f9abdb13: Fix T83361: UV Editor does not draw pinned selected UVs as pinned
rB2b9eb5eee58a: Fix T83361: UV Editor does not draw pinned selected UVs as pinned
Summary

Caused by rB4212b6528af.

outlineColor is computed by the vertex shader, so not a uniform.
So outlineColor was undefined.

note: it was still possible to run into the situation that a selected UV
is drawn ontop of a selected pinned UV [you had to disable sticky
selection for this], now also make sure selected-pinned are drawn
topmost, then selected, then unselected UVs.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 8 2020, 4:11 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B11619: Diff 31739.Dec 8 2020, 4:11 PM
Philipp Oeser (lichtwerk) added projects: Restricted Project, EEVEE & Viewport.Dec 8 2020, 4:11 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 31807.Dec 10 2020, 9:26 AM

make sure selected-pinned UVs are drawn on top of selected (otherwise outline of pinned was not visible if they were z-fighting)

Harbormaster completed remote builds in B11658: Diff 31807.Dec 10 2020, 9:26 AM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Dec 10 2020, 9:26 AM
Jeroen Bakker (jbakker) accepted this revision.Dec 10 2020, 9:52 AM
This revision is now accepted and ready to land.Dec 10 2020, 9:52 AM
Closed by commit rB2b9eb5eee58a: Fix T83361: UV Editor does not draw pinned selected UVs as pinned (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 10 2020, 1:23 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB2b9eb5eee58a: Fix T83361: UV Editor does not draw pinned selected UVs as pinned.
Jeroen Bakker (jbakker) added a commit: rB04c7f9abdb13: Fix T83361: UV Editor does not draw pinned selected UVs as pinned.Jan 13 2021, 3:10 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
overlay/
shaders/
3 lines
2 lines

Diff 31817

View Options

source/blender/draw/engines/overlay/shaders/edit_uv_verts_frag.glsl

Loading...
View Options

source/blender/draw/engines/overlay/shaders/edit_uv_verts_vert.glsl

Loading...