Paths

Table of Contentst

Geometry Nodes: Attribute fill node
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Dec 8 2020, 6:24 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
Dalai Felinto (dfelinto)

Group Reviewers

Geometry Nodes

Commits

rB348bd319d5a8: Geometry Nodes: Attribute Fill Node

Summary

I saw this happen twice in stuff people have been sharing:

Since the min and max are the same, it just fills every element of the
attribute with the same value. This is an unfortunate hacky way to do
this, and it makes sense to have a specific node, an "Attribute Fill"
node.

An immediate use case is for "billboard" scattering:

Diff Detail

Repository

rB Blender

Branch

geometry-nodes-attribute-fill (branched from master)

Build Status

Buildable 11623
Build 11623: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Dec 8 2020, 6:24 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B11623: Diff 31746.Dec 8 2020, 6:25 PM

Hans Goudey (HooglyBoogly) added a reviewer: Geometry Nodes.Dec 8 2020, 6:25 PM

Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Dimitri Bastos (DimitriBastos) awarded a token.Dec 8 2020, 6:46 PM

LGTM.

source/blender/nodes/geometry/nodes/node_geo_attribute_fill.cc
49	Should be `const CustomDataType data_type`. This can make debugging easier.

This revision is now accepted and ready to land.Dec 9 2020, 5:28 PM

Dalai Felinto (dfelinto) accepted this revision as: Dalai Felinto (dfelinto).Dec 10 2020, 9:47 AM

Closed by commit rB348bd319d5a8: Geometry Nodes: Attribute Fill Node (authored by Hans Goudey (HooglyBoogly)). · Explain WhyDec 10 2020, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB348bd319d5a8: Geometry Nodes: Attribute Fill Node.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

nodeitems_builtins.py

1 line

source/

blender/

blenkernel/

BKE_node.h

1 line

intern/

node.c

1 line

editors/

space_node/

drawnode.c

11 lines

makesrna/

intern/

rna_nodetree.c

31 lines

nodes/

CMakeLists.txt

1 line

NOD_geometry.h

1 line

NOD_static_types.h

1 line

geometry/

nodes/

node_geo_attribute_fill.cc

130 lines

Diff 31746

View Options

release/scripts/startup/nodeitems_builtins.py

View Options

source/blender/blenkernel/BKE_node.h

View Options

source/blender/blenkernel/intern/node.c

View Options

source/blender/editors/space_node/drawnode.c

View Options

source/blender/makesrna/intern/rna_nodetree.c

View Options

source/blender/nodes/CMakeLists.txt

View Options

source/blender/nodes/NOD_geometry.h

View Options

source/blender/nodes/NOD_static_types.h

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_fill.cc

Geometry Nodes: Attribute fill nodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31746

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.c

source/blender/editors/space_node/drawnode.c

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/node_geo_attribute_fill.cc

Geometry Nodes: Attribute fill node
ClosedPublic
Actions

Revision Contents
Changeset List