Page MenuHome

Correct the order of the last two arguments in `eevee_cryptomatte_shading_group_create`
ClosedPublic

Authored by Evan Wilson (EAW) on Dec 10 2020, 11:04 AM.

Details

Summary

When compiling on Windows, the following warnings occur:

[3468/4560] Building C object source\blender\draw\CMakeFiles\bf_draw.dir\engines\eevee\eevee_cryptomatte.c.obj
C:\blender-git\blender\source\blender\draw\engines\eevee\eevee_cryptomatte.c(306): warning C4047: 'function': 'bool' differs in levels of indirection from 'void *'
C:\blender-git\blender\source\blender\draw\engines\eevee\eevee_cryptomatte.c(306): warning C4024: 'eevee_cryptomatte_shading_group_create': different types for formal and actual parameter 5

As @Julian Eisel (Severin) pointed out here, this is due to the last two arguments being flipped. This diff corrects the order.

Diff Detail

Repository
rB Blender

Event Timeline

Evan Wilson (EAW) requested review of this revision.Dec 10 2020, 11:04 AM
Evan Wilson (EAW) created this revision.
Evan Wilson (EAW) retitled this revision from Correct the order of the last two arguements in `eevee_cryptomatte_shading_group_create` to Correct the order of the last two arguments in `eevee_cryptomatte_shading_group_create`.Dec 10 2020, 11:10 AM
Evan Wilson (EAW) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 10 2020, 11:24 AM

I don’t have commit rights, so if someone could be so kind as to land this patch, I would appreciate it.