Page MenuHome
Differential D9816

Translations: Use ASAN_OPTIONS from environment also.
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Dec 10 2020, 4:48 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rBA589d13408a60: Translations: Use ASAN_OPTIONS from environment too.
Summary

See D9815

Diff Detail

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Dec 10 2020, 4:48 PM
Ankit Meel (ankitm) created this revision.
Harbormaster completed remote builds in B11668: Diff 31823.Dec 10 2020, 4:48 PM
Ankit Meel (ankitm) added a parent revision: D9815: Tests, docs: Use ASAN_OPTIONS from environment also..Dec 10 2020, 4:50 PM
Ankit Meel (ankitm) added a reviewer: Bastien Montagne (mont29).Dec 10 2020, 5:00 PM
Ankit Meel (ankitm) added a project: Translations.
Bastien Montagne (mont29) accepted this revision.Dec 10 2020, 5:32 PM
This revision is now accepted and ready to land.Dec 10 2020, 5:32 PM
Ankit Meel (ankitm) updated this revision to Diff 31836.Dec 10 2020, 8:53 PM
  • Fix error

I should not edit Python and CMake together.. Could you have a look again please ?

Harbormaster completed remote builds in B11677: Diff 31836.Dec 10 2020, 8:53 PM
Bastien Montagne (mont29) requested changes to this revision.Dec 10 2020, 11:06 PM
Bastien Montagne (mont29) added inline comments.
ui_translate/update_svn.py
80–81

env["ASAN_OPTIONS"] = "exitcode=0:" + os.environ.get(ASAN_OPTIONS, "")?

This revision now requires changes to proceed.Dec 10 2020, 11:06 PM
Ankit Meel (ankitm) updated this revision to Diff 31901.Dec 11 2020, 11:13 PM
  • Simplify using get()'s default
Harbormaster completed remote builds in B11703: Diff 31901.Dec 11 2020, 11:13 PM
Bastien Montagne (mont29) accepted this revision.Dec 12 2020, 7:28 AM
This revision is now accepted and ready to land.Dec 12 2020, 7:28 AM
Bastien Montagne (mont29) added a comment.Jan 8 2021, 10:46 AM

@Ankit Meel (ankitm) Any reason why this has not yet been committed?

Ankit Meel (ankitm) added a comment.Jan 8 2021, 10:47 AM


Thought I'll do them both together.

Closed by commit rBA589d13408a60: Translations: Use ASAN_OPTIONS from environment too. (authored by Ankit Meel (ankitm)). · Explain WhyJan 8 2021, 11:03 AM
This revision was automatically updated to reflect the committed changes.
Ankit Meel (ankitm) added a commit: rBA589d13408a60: Translations: Use ASAN_OPTIONS from environment too..
Ankit Meel (ankitm) mentioned this in rB27e2c5ab7831: Tests, docs: Use sanitizer options from environment too..Jan 29 2021, 9:46 AM

Revision Contents
Changeset List

PathSize
ui_translate/
2 lines

Diff 32534

View Options

ui_translate/update_svn.py

Loading...