Page MenuHome
Differential D9831

Fix: BLI_getenv returns ascii rather than UTF-8 on windows
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Dec 11 2020, 6:49 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T74510: Various Addons using filesystem properties (PROP_FILEPATH etc): UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 24: invalid continuation byte
Commits
rB87b19b3aba0c: Fix: BLI_getenv returns ascii not UTF8 on windows
Summary

T74510 seems to be turning into a jumble of various encoding
related issues, this is one of them.

This specific patch fixes the incorrect behaviour of BLI_getenv returning ascii on windows rather than utf-8 resulting in problems when using the BLENDER_USER_CONFIG environment variable to point to a path with non ascii characters.

all tests pass on windows, given all code is in a windows only guard no testing should be needed on other platforms.

Diff Detail

Repository
rB Blender
Branch
tmp_getenv_utf8 (branched from master)
Build Status
Buildable 11695
Build 11695: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Dec 11 2020, 6:49 PM
Ray Molenkamp (LazyDodo) created this revision.
Harbormaster completed remote builds in B11695: Diff 31889.Dec 11 2020, 6:49 PM
Ray Molenkamp (LazyDodo) added a task: T74510: Various Addons using filesystem properties (PROP_FILEPATH etc): UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 24: invalid continuation byte.Dec 11 2020, 6:51 PM
Brecht Van Lommel (brecht) accepted this revision.Dec 11 2020, 7:07 PM
This revision is now accepted and ready to land.Dec 11 2020, 7:07 PM
Closed by commit rB87b19b3aba0c: Fix: BLI_getenv returns ascii not UTF8 on windows (authored by Ray Molenkamp (LazyDodo)). · Explain WhyDec 11 2020, 7:59 PM
This revision was automatically updated to reflect the committed changes.
Ray Molenkamp (LazyDodo) added a commit: rB87b19b3aba0c: Fix: BLI_getenv returns ascii not UTF8 on windows.
Ray Molenkamp (LazyDodo) added inline comments.Dec 11 2020, 8:10 PM
source/blender/blenlib/intern/path_util.c
1329

Seems like we both missed the memleak here, if the buffer was valid, but didn't fit in the static buffer, unlikely to happen, but still sloppy. fixed in rB0dbbcaf1e6bb

Raimund Klink (Raimund58) awarded a token.Dec 12 2020, 9:58 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
intern/
27 lines

Diff 31889

View Options

source/blender/blenlib/intern/path_util.c

Loading...