This adds the missing options for the effects as it is done in modifiers.
Details
Details
- Reviewers
Hans Goudey (HooglyBoogly) - Maniphest Tasks
- T83696: Add Additional options menu to Effects panel
- Commits
- rB6327771bc968: Fix T83696: Add Additional menu to Effects panel
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- R292-copy-effects (branched from master)
- Build Status
Buildable 11721 Build 11721: arc lint + arc unit
Event Timeline
Comment Actions
Looks pretty good, just two pieces of feedback:
- The copied effect should be placed right after the one you're acting on
- The copy operator should have a shortcut in the keymaps-- blender default shift D and industry compatible ctrl-D
Side note: I'll be working on adding the "active modifier" concept for the gpencil modifiers, constraints, and effects for 2.92.
Comment Actions
@Hans Goudey (HooglyBoogly) I don't find the Industry compatible keymaps. Where is this file? I looked and I have found only the normal keymaps.
Other issues solved.
Comment Actions
Other than one note this looks good to me.
| source/blender/editors/object/object_shader_fx.c | ||
|---|---|---|
| 663 | This shouldn't be necessary, right? There is no geometry being recalculated for effects? I see it all over this file though, looks like it was just copied from the modifier code? Or this flag is being quite abused. | |
Comment Actions
@Hans Goudey (HooglyBoogly) Yes, it's needed..if you remove the depsgraph tag, the sreen is not updated. I guess the draw engine need it.
Comment Actions
Here is part of the description of that flag from`DNA_ID.h`:
* When object of other type is tagged with this flag it makes the modifier * stack to be re-evaluated.
So maybe it's not a big deal, but it doesn't seem like the grease pencil modifier stack needs to be recalculated whenever a shader effect is changed.