I do not think the overflow test is properly structured. From my understanding is that the actual intent is to verify MEM_size_safe_multiply is working correct. So, test should directly test MEM_size_safe_multiply(). Making a pass/fail decision based on an indirect indication is not really nice.

If we go way of silencing warning

That is for you (plural) to decide, I'm just making it work somehow.

@Sybren A. Stüvel (sybren), Eeeh. That's kind of annoying :(

I would say that tests needs to be simple and reliable. Those ASAN flags manipulation doesn't seem to be really robust.

Unless there is really good reason to really do allocation overflow test, I'd say test MEM_size_safe_multiply() and don't do overflow allocation from tests.

In D9844#251935, @Sergey Sharybin (sergey) wrote:

@Sybren A. Stüvel (sybren), Eeeh. That's kind of annoying :(

It is, indeed. We could also rename the file, remove the entire idea of keeping track of our changes w.r.t. upstream, and just consider the file "ours". That's out of scope of this patch, though.

I would say that tests needs to be simple and reliable. Those ASAN flags manipulation doesn't seem to be really robust.

Unless there is really good reason to really do allocation overflow test, I'd say test MEM_size_safe_multiply() and don't do overflow allocation from tests.

I don't have an opinion here.

For example, look at how LSAN_OPTIONS is set in build_files/cmake/Modules/GTestTesting.cmake:

@Sybren A. Stüvel (sybren) That works because the test target is added before set_tests_properties using add_test.
For GTest, targets are created when ctest is invoked using the "discover" method.
Process is something like (as I understand it) configure -> build test executables -> invoke ctest: ctest -N -> test targets are created -> list of tests is shown.
Since target doesn't exist at configure time, properties cannot be set then.

The ASAN documentation states:

you could also embed default flags in the source code by implementing __asan_default_options function:

const char *__asan_default_options() {
  return "verbosity=1:malloc_context_size=20";
}

I think it would be a cleaner solution to have the offending test built as a separate executable that contains this function. That way the change required would be more localized.