Page MenuHome
Differential D9847

Use property name for "Flip UDIM" UI element
ClosedPublic
Actions

Authored by David Swift (rococo) on Dec 14 2020, 2:09 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)

Diff Detail

Repository
rB Blender
Branch
arcpatch-D9846 (branched from master)
Build Status
Buildable 11725
Build 11725: arc lint + arc unit

Event Timeline

David Swift (rococo) requested review of this revision.Dec 14 2020, 2:09 AM
David Swift (rococo) created this revision.
Harbormaster completed remote builds in B11725: Diff 31946.Dec 14 2020, 2:09 AM
David Swift (rococo) mentioned this in D9846: Cleanup: Remove some label redefinitions in mirror UI.Dec 14 2020, 2:16 AM
David Swift (rococo) added a reviewer: Hans Goudey (HooglyBoogly).
David Swift (rococo) added a project: Modifiers.
Hans Goudey (HooglyBoogly) accepted this revision.Dec 14 2020, 2:31 AM

Thanks!

This revision is now accepted and ready to land.Dec 14 2020, 2:31 AM
Hans Goudey (HooglyBoogly) closed this revision.Dec 14 2020, 6:08 AM

Agh, I was getting ready to commit this, but it turns out the property definition UI name was "Mirror UDIM" rather than "Flip UDIM" which is the name exposed in the UI.
I think "Mirror UDIM" is marginally better because it doesn't introduce a new term, but the difference is so subtle that in this case it's not worth changing the manual and very slightly invalidating any tutorial made about the feature.

So I think I'm going to close this patch. Sorry to waste you're time making this patch, thanks for looking into it anyway.

David Swift (rococo) added a comment.Dec 14 2020, 6:14 AM

No worries! Appreciate the attention to detail and a chance to practice the workflow. The next one will be better!

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
2 lines

Diff 31946

View Options

source/blender/modifiers/intern/MOD_mirror.c

Loading...