Page MenuHome
Differential D9854

UI: Corrects the text alignment of the RGB/HSV/Hex toggle in the color picker
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Dec 14 2020, 10:17 PM.

Details

Reviewers
Julian Eisel (Severin)
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T84869: Expanded enums now always draw center aligned (was left aligned)
T80313: "Searc" Typo on Button in Quick Setup Dialog
Commits
rBcab26abbdb07: UI: Correct the text alignment of the RGB/HSV/Hex toggle in the color picker
Summary

UI: Corrects the text alignment of the RGB/HSV/Hex toggle in the color picker

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Dec 14 2020, 10:17 PM
Yevgeny Makarov (jenkm) created this revision.
Yevgeny Makarov (jenkm) mentioned this in D9853: UI: Adjust Layout on Quick Setup Screen.Dec 23 2020, 9:14 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 32361.Jan 1 2021, 11:07 AM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) added a reviewer: Hans Goudey (HooglyBoogly).
Yevgeny Makarov (jenkm) updated this revision to Diff 32363.Jan 1 2021, 4:40 PM
Hans Goudey (HooglyBoogly) mentioned this in T84869: Expanded enums now always draw center aligned (was left aligned).Jan 20 2021, 2:23 PM
Philipp Oeser (lichtwerk) added a task: T84869: Expanded enums now always draw center aligned (was left aligned).Jan 20 2021, 2:29 PM
Yevgeny Makarov (jenkm) retitled this revision from Revert: Fix T80313: Fix clipped text in splash screen on hiDPI monitors to Fix T84869: Expanded enums now always draw center aligned.Jan 28 2021, 2:26 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Julian Eisel (Severin) requested changes to this revision.Feb 1 2021, 8:34 PM

It's hard to foresee what not setting UI_BLOCK_LOOP will have as consequences. Think it would mostly be fine. But I did notice it behaves incorrectly (as in, not as before) when the window size is changed.

For the 2.92 release I think we should just revert my fix and live with the small visual glitch.

This revision now requires changes to proceed.Feb 1 2021, 8:34 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 33422.Feb 2 2021, 9:55 AM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) added a comment.Feb 2 2021, 10:05 AM

The "Load Settings" and "Save New Settings" buttons can be implemented in C, which will allow you to center the text.
And I think that not to expand enums is a good enough solution to "fix" the others.

Yevgeny Makarov (jenkm) updated this revision to Diff 33606.Feb 5 2021, 3:26 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) added a comment.Feb 5 2021, 4:21 PM

@Julian Eisel (Severin) maybe something like this? P1947

Julian Eisel (Severin) mentioned this in rBb1142858d4ca: Revert "Fix T80313: Fix clipped text in splash screen on hiDPI monitors".Feb 19 2021, 7:05 PM
Julian Eisel (Severin) accepted this revision.Feb 19 2021, 7:15 PM

Committed the revert itself to the release branch, b1142858d4ca.
Could you update this patch and the description, to make clear that this only corrects the color picker text alignment? This can go into master then.

This revision is now accepted and ready to land.Feb 19 2021, 7:15 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 34208.Feb 20 2021, 10:57 AM
Yevgeny Makarov (jenkm) retitled this revision from Fix T84869: Expanded enums now always draw center aligned to UI: Corrects the text alignment of the RGB/HSV/Hex toggle in the color picker.
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Closed by commit rBcab26abbdb07: UI: Correct the text alignment of the RGB/HSV/Hex toggle in the color picker (authored by Yevgeny Makarov (jenkm), committed by Julian Eisel (Severin)). · Explain WhyFeb 20 2021, 6:55 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rBcab26abbdb07: UI: Correct the text alignment of the RGB/HSV/Hex toggle in the color picker.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
3 lines

Diff 34219

View Options

source/blender/editors/interface/interface_region_color_picker.c

Loading...