Page MenuHome
Differential D9861

Geometry Nodes: New Attribute Color Ramp node.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 15 2020, 12:10 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T82585: Attribute Color Ramp for trees and flowers scenarios
Commits
rB0eedba328df3: Geometry Nodes: add Attribute Color Ramp node
Summary

Ref T82585.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Dec 15 2020, 12:10 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B11752: Diff 32001.Dec 15 2020, 12:10 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Dec 15 2020, 12:11 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Jacques Lucke (JacquesLucke) added a project: Geometry Nodes.
Jacques Lucke (JacquesLucke) added a task: T82585: Attribute Color Ramp for trees and flowers scenarios.
Hans Goudey (HooglyBoogly) accepted this revision.Dec 16 2020, 4:53 PM

Looks good. We'll need to make this use the input attribute's domain when we have some sort of helper function for that. Maybe a comment on result_domain = ATTR_DOMAIN_POINT; could mention that briefly so we don't forget.

This revision is now accepted and ready to land.Dec 16 2020, 4:53 PM
Kenzie (kenziemac130) awarded a token.Dec 16 2020, 6:09 PM
Kenzie (kenziemac130) added a subscriber: Kenzie (kenziemac130).

Awesome! Would be nice to be able to expose the color ramp to the modifier input similarly to object selection.

Closed by commit rB0eedba328df3: Geometry Nodes: add Attribute Color Ramp node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyDec 17 2020, 12:02 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB0eedba328df3: Geometry Nodes: add Attribute Color Ramp node.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
1 line
source/
blender/
blenkernel/
1 line
intern/
1 line
editors/
space_node/
10 lines
makesdna/
4 lines
makesrna/
intern/
12 lines
nodes/
1 line
1 line
1 line
geometry/
nodes/
107 lines

Diff 32096

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/blenkernel/intern/node.c

Loading...
View Options

source/blender/editors/space_node/drawnode.c

Loading...
View Options

source/blender/makesdna/DNA_node_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/nodes/CMakeLists.txt

Loading...
View Options

source/blender/nodes/NOD_geometry.h

Loading...
View Options

source/blender/nodes/NOD_static_types.h

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_color_ramp.cc

Loading...