Page MenuHome

Fix T83801: UVEditor translation ignores "Pixel Coordinates" and aspect ratio
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Dec 16 2020, 11:04 AM.

Details

Summary

Caused by rB4eda60c2d82d.

T83801 reported not moving in pixel space, but even without that toggle
above commit caused the translation to not take apsect ratio into
account properly [a translation of 1 on the x axis for example on an
image with non 1:1 aspect ration caused the UVs to not end up in the
same place on the next 'tile']

Above commit removed 'removeAspectRatio()' [the counterpart of
applyAspectRatio -- which does the pixel coord correction internally]
from 'applyTranslation()'.

This was also reported in T83352 [which was closed by rBf3b08af24c9f --
but that only solved the displax in header, not the actual
transformation]

Now bring back 'removeAspectRatio()'.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 16 2020, 11:04 AM
Philipp Oeser (lichtwerk) added a project: Restricted Project.Dec 16 2020, 11:42 AM

I suppose you wanted to refer to commit rB4eda60c2d82d instead of rB4212b6528af

The call complies as before (with the T_2D_EDIT check added).

So looks good :)

(I noticed there is a room for cleanup, but it is something apart).

This revision is now accepted and ready to land.Dec 16 2020, 2:43 PM

I suppose you wanted to refer to commit rB4eda60c2d82d instead of rB4212b6528af

Opps, how did that get in here :) Thx noting!