Ref: T82651
Normally people use "Combine XYZ" to input a vector, but it is more
interesting to have an explicit vector input.
So this is basically "Combine XYZ" without any input sockets, the values
are stored in the node itself.
Details
Details
- Reviewers
Jacques Lucke (JacquesLucke) - Commits
- rBf43561eae682: Function Nodes: Input Vector
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- temp-vector-input (branched from master)
- Build Status
Buildable 11807 Build 11807: arc lint + arc unit
Event Timeline
Comment Actions
Beside the few mentioned style issues, this looks good :)
| source/blender/editors/space_node/drawnode.c | ||
|---|---|---|
| 3311 | missing break | |
| source/blender/makesrna/intern/rna_nodetree.c | ||
| 4506 | same line twice | |
| source/blender/nodes/function/nodes/node_fn_input_vector.cc | ||
| 26 | fh -> fn | |
| 33 | Can be shortened to builder.construct_and_set_matching_fn<blender::fn::CustomMF_Constant<blender::float3>>(vector); | |
| 40 | inpput | |
Comment Actions
Thanks, committed on f43561eae6826eead2e5e78bc8792b3c15dda6ae.
| source/blender/blenkernel/BKE_node.h | ||
|---|---|---|
| 1372 | @Jacques Lucke (JacquesLucke) it could be FN_NODE_VECTOR instead, what do you think? | |
| source/blender/blenkernel/BKE_node.h | ||
|---|---|---|
| 1372 | I don't really care currently. This name is not stored in files, so it doesn't matter too much. FN_NODE_INPUT_VECTOR sounds good to me. | |