Page MenuHome

Fix T83868: Button animation states no longer visible without emboss
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Dec 18 2020, 10:36 PM.

Details

Summary

This bug was caused by making it so that non-embossed modifier icon
buttons could become an operator button and retain their red highlight
for disabled modifiers. The icon button needs emboss turned off, but
in earlier versions of Blender, UI_EMBOSS_NONE would be overridden
by animation or red alert states.

Instead of abusing "NONE" to mean "none unless there is animation or
red alert", this commit adds a new emboss flag for that situation,
UI_EMBOSS_NONE_OR_STATUS, which uses no emboss unless there is an
animation state, or another status. There are only a few situations
where this is necessary, so the change isn't too big.

Diff Detail

Repository
rB Blender
Branch
fix-no-anim-emboss (branched from master)
Build Status
Buildable 11826
Build 11826: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Dec 18 2020, 10:36 PM
Hans Goudey (HooglyBoogly) created this revision.

Quickly checked the code, looks reasonable!

source/blender/editors/include/UI_interface.h
112–113

Comment needs correction.

This revision is now accepted and ready to land.Dec 18 2020, 10:43 PM
Hans Goudey (HooglyBoogly) marked an inline comment as done.Dec 19 2020, 12:10 AM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/editors/include/UI_interface.h
112–113

Oops, thanks