UI fix: "Spot Shape" properties for spot lights were displayed incorrectly in Cycles
ClosedPublic
Actions

Authored by Matteo Falduto (matteolegna) on Dec 19 2020, 11:00 PM.

Details

Reviewers

Julian Eisel (Severin)
Brecht Van Lommel (brecht)

Group Reviewers

User Interface

Commits

rCca8a69da3813: UI: make light spot shape panel consistent between Cycles and Eevee
rB985528c9b989: UI: make light spot shape panel consistent between Cycles and Eevee

Summary

The "Spot Shape" property panel for Spot Lights is arranged in the UI in an inconsistent way across Cycles and EEVEE. This patch harmonizes the way it looks, favoring the way it currently is in EEVEE.

Diff Detail

Repository

rB Blender

Branch

spot_ui (branched from master)

Build Status

Buildable 11831
Build 11831: arc lint + arc unit

Event Timeline

Matteo Falduto (matteolegna) requested review of this revision.Dec 19 2020, 11:00 PM

Matteo Falduto (matteolegna) created this revision.

Harbormaster completed remote builds in B11830: Diff 32188.Dec 19 2020, 11:00 PM

Matteo Falduto (matteolegna) edited the summary of this revision. (Show Details)Dec 19 2020, 11:02 PM

Matteo Falduto (matteolegna) added a reviewer: User Interface.

Matteo Falduto (matteolegna) added a subscriber: Matteo Falduto (matteolegna).

Matteo Falduto (matteolegna) edited the summary of this revision. (Show Details)Dec 19 2020, 11:10 PM

Matteo Falduto (matteolegna) added a reviewer: Julian Eisel (Severin).Dec 19 2020, 11:12 PM

Matteo Falduto (matteolegna) edited the summary of this revision. (Show Details)Dec 19 2020, 11:20 PM

In addition, I am just noticing now, those properties also lack the little keyframe button at their right.

Re-implementing the keyframe decorator

Harbormaster completed remote builds in B11831: Diff 32190.Dec 20 2020, 12:03 AM

Brecht Van Lommel (brecht) accepted this revision.Dec 21 2020, 4:13 PM

This revision is now accepted and ready to land.Dec 21 2020, 4:13 PM

Closed by commit rB985528c9b989: UI: make light spot shape panel consistent between Cycles and Eevee (authored by Matteo Falduto (matteolegna), committed by Brecht Van Lommel (brecht)). · Explain WhyDec 21 2020, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB985528c9b989: UI: make light spot shape panel consistent between Cycles and Eevee.

Stefan Werner (swerner) added a commit: rCca8a69da3813: UI: make light spot shape panel consistent between Cycles and Eevee.Mar 1 2021, 2:20 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

blender/

addon/

ui.py

2 lines

Diff 32190

View Options

intern/cycles/blender/addon/ui.py

UI fix: "Spot Shape" properties for spot lights were displayed incorrectly in CyclesClosedPublicActions