Page MenuHome
Differential D9909

Fix for T83989 Geometry Nodes: Attribute Math Node Always Adds Its Operands Regardless of the Operator Setting
ClosedPublic
Actions

Authored by Garry R. Osgood (grosgood) on Dec 20 2020, 7:40 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Commits
rB84cc00f3b68e: Fix T83989: Attribute Math node ignores its operation setting
Summary

T83989 observes that the Attribute Math node always adds its operands regardless of its operator setting. This seems to stem from a simple oversight committed with rB23233fcf056e42958972d129ba526c0a103cf179, which overlooked adjusting attribute_math_calc() to avail itself of the new storage location. This patch strives to address that issue.
Related
This patch may have bearing on T83906 as well.

Diff Detail

Repository
rB Blender

Event Timeline

Garry R. Osgood (grosgood) requested review of this revision.Dec 20 2020, 7:40 PM
Garry R. Osgood (grosgood) created this revision.
Hans Goudey (HooglyBoogly) accepted this revision.Dec 21 2020, 1:41 AM

Wow, cheers for the complete report and submitting it with a patch. Indeed an oversight on my part, sorry about that.

I'll commit this now

This revision is now accepted and ready to land.Dec 21 2020, 1:41 AM
Closed by commit rB84cc00f3b68e: Fix T83989: Attribute Math node ignores its operation setting (authored by Garry R. Osgood (grosgood), committed by Hans Goudey (HooglyBoogly)). · Explain WhyDec 21 2020, 1:48 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB84cc00f3b68e: Fix T83989: Attribute Math node ignores its operation setting.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
3 lines

Diff 32205

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_math.cc

Loading...