Page MenuHome
Differential D9919

Update addons for D9697 "_RNA_UI" removal
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Dec 22 2020, 7:30 PM.

Details

Reviewers
Alexander Gavrilov (angavrilov)
Commits
rBA104ba1c56820: Update addons for D9697 "_RNA_UI" removal
Summary

This is a followup patch for D9697 which applies the changes to the addon reporistory.
Almost all of the changes are in rigify, but there is one small change in "curve_tools"
and two trivial changes in IO addons.

I don't have much experience with Rigify, so I haven't been able to do the most thorough
testing, but I have tested by creating rigs and inspecting their custom properties.
The changes are relatively simple anyway, it's just slightly changing the functions used
to create and copy custom property UI data.

Diff Detail

Repository
rBA Blender Add-ons
Branch
refactor-idprop-ui-data-addons
Build Status
Buildable 16649
Build 16649: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) created this revision.Dec 22 2020, 7:30 PM
Harbormaster completed remote builds in B11860: Diff 32243.Dec 22 2020, 7:30 PM
Hans Goudey (HooglyBoogly) requested review of this revision.Dec 22 2020, 7:30 PM
Hans Goudey (HooglyBoogly) mentioned this in D9697: Refactor IDProperty UI data storage.Dec 22 2020, 7:31 PM
Hans Goudey (HooglyBoogly) added a reviewer: Alexander Gavrilov (angavrilov).Dec 22 2020, 7:33 PM
Hans Goudey (HooglyBoogly) added a parent revision: D9697: Refactor IDProperty UI data storage.Mar 10 2021, 6:39 PM
Hans Goudey (HooglyBoogly) planned changes to this revision.May 11 2021, 11:44 PM

I will update this patch for the changes in the parent patch. For my reference:

update_rna -> rna_ui_data_update
rna_data -> rna_ui_data
clear_rna -> rna_ui_data_clear
copy_rna -> rna_ui_data_copy
custom_properties -> id_properties_create
Hans Goudey (HooglyBoogly) updated this revision to Diff 41064.Aug 25 2021, 1:09 AM
  • Update for latest changes in D9697
Harbormaster completed remote builds in B16600: Diff 41064.Aug 25 2021, 1:09 AM
Alexander Gavrilov (angavrilov) requested changes to this revision.Aug 25 2021, 9:09 AM
Alexander Gavrilov (angavrilov) added inline comments.
curve_tools/auto_loft.py
35

Seems to be an extra comma here.

rigify/utils/mechanism.py
445

What is the point of this replacement of get?

520

Likewise, what's the point of changes here? Especially the name line makes no sense.

This revision now requires changes to proceed.Aug 25 2021, 9:09 AM
Alexander Gavrilov (angavrilov) added a comment.Aug 25 2021, 12:31 PM

Also, I don't know what is the object returned by id_properties_ui like, but maybe consider changing the code to avoid to_dict - possibly using getattr if needed or something.

To test custom property copying code, find a basic.super_copy rig in the metarig (e.g. shoulder bones), and add some custom properties to the metarig bone. They would be automatically copied to the generated control using the utilities touched in this patch.

Hans Goudey (HooglyBoogly) updated this revision to Diff 41148.Aug 27 2021, 7:13 AM
Hans Goudey (HooglyBoogly) marked 3 inline comments as done.
  • Fix errors in changes, simplify with .get()

Sorry for the messiness in the earlier version of this patch. I admit I
didn't check it over properly when messaging you about it in chat.

The changes should be simpler now, and the cases you pointed out fixed.
And thanks for the tip about testing. I haven't encountered unexpected behavior in my tests.

Refactoring to avoid to_dict wouldn't be possible without changing the API,
which I'd like to avoid at this point. The UI data values aren't properties
currently because their presence depends on the IDProperty type.

Harbormaster completed remote builds in B16648: Diff 41148.Aug 27 2021, 7:13 AM
Hans Goudey (HooglyBoogly) updated this revision to Diff 41149.Aug 27 2021, 7:14 AM
  • Remove one last change
Harbormaster completed remote builds in B16649: Diff 41149.Aug 27 2021, 7:14 AM
Alexander Gavrilov (angavrilov) accepted this revision.Aug 27 2021, 12:51 PM

Seems ok now.

This revision is now accepted and ready to land.Aug 27 2021, 12:51 PM
Hans Goudey (HooglyBoogly) mentioned this in rB8b9a3b94fc14: Refactor IDProperty UI data storage.Aug 27 2021, 3:28 PM
Closed by commit rBA104ba1c56820: Update addons for D9697 "_RNA_UI" removal (authored by Hans Goudey (HooglyBoogly)). · Explain WhyAug 27 2021, 3:30 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBA104ba1c56820: Update addons for D9697 "_RNA_UI" removal.
MKRelax (MKRelax) added a subscriber: MKRelax (MKRelax).Jan 16 2022, 3:17 PM
MKRelax (MKRelax) added inline comments.
add_camera_rigs/build_rigs.py
327

soft_max = 5000.0 seems wrong. It was probably copied/pasted from line 161 above.
Looking at the old code, it should be soft_min=0.0, soft_max=1.0.

Hans Goudey (HooglyBoogly) added inline comments.Jan 17 2022, 7:24 PM
add_camera_rigs/build_rigs.py
327

Thanks for finding this., it does look like a typo. In this case, since the hard max and soft max are the same, specifying the soft max shouldn't be necessary. I'll commit a fix.

Revision Contents
Changeset List

PathSize
add_camera_rigs/
28 lines
curve_tools/
16 lines
io_scene_fbx/
2 lines
io_scene_gltf2/
blender/
com/
2 lines
rigify/
2 lines
utils/
24 lines

Diff 41149

View Options

add_camera_rigs/build_rigs.py

Loading...
View Options

curve_tools/auto_loft.py

Loading...
View Options

io_scene_fbx/export_fbx_bin.py

Loading...
View Options

io_scene_gltf2/blender/com/gltf2_blender_extras.py

Loading...
View Options

rigify/generate.py

Loading...
View Options

rigify/utils/mechanism.py

Loading...