Fix: Knife tool renders future points incorrectly once again.
AbandonedPublic
Actions

Authored by Janusch Patas (patjan) on Dec 25 2020, 2:06 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T83391: Knife tool renders future points incorrectly once again

Summary

The root cause is that sometimes DRW_culling_min_max_test returns true. In fact DRW_culling_min_max_test gives an index to a wrong face. You can find further details on this behavior and why the initial fix was made in T65585.

Diff Detail

Repository

rB Blender

Branch

Fix-T83391 (branched from master)

Build Status

Buildable 11882
Build 11882: arc lint + arc unit

Event Timeline

Janusch Patas (patjan) requested review of this revision.Dec 25 2020, 2:06 PM

Janusch Patas (patjan) created this revision.

Harbormaster completed remote builds in B11882: Diff 32281.Dec 25 2020, 2:06 PM

Janusch Patas (patjan) edited the summary of this revision. (Show Details)Dec 25 2020, 2:09 PM

Janusch Patas (patjan) added a reviewer: Modeling.

Janusch Patas (patjan) added a project: Modeling.

Janusch Patas (patjan) mentioned this in T83391: Knife tool renders future points incorrectly once again.Dec 25 2020, 2:13 PM

Janusch Patas (patjan) updated this revision to Diff 32290.Dec 27 2020, 12:22 AM

Janusch Patas (patjan) edited the summary of this revision. (Show Details)

This comment was removed by Janusch Patas (patjan).

Harbormaster completed remote builds in B11887: Diff 32290.Dec 27 2020, 12:22 AM

Correction: Wrong Differential

Harbormaster completed remote builds in B11888: Diff 32291.Dec 27 2020, 12:30 AM

@Campbell Barton (campbellbarton) think that one would be for you?

Evan Wilson (EAW) added a task: T83391: Knife tool renders future points incorrectly once again.Mar 29 2021, 1:21 AM

Looking into this and I think it's solving the problem at the wrong level.

The issue is caused by the face being set, without KnifePosData.co & KnifePosData.cage being set.

In this case when the face is set, there is an incorrect assumption in knife_update_active.

Committed alternate fix rB27a7b2e27ae8088dccfa87e66c820dc2e37c113a

Note that this part of the knife code can use further improvements, the API for finding the nearest geometry elements should also be documented more clearly.