This patch addresses the issue described in T83122. The Surface -> Nurbs Curve behaves now like the Curve -> Nurbs Curve, if you initially select less than all points. So, multiple points can be selected and extruded which just moves the selected points similar to Curve -> Nurbs Curve object.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- Fix-T83122NurbsExtruding (branched from master)
- Build Status
Buildable 11889 Build 11889: arc lint + arc unit
Event Timeline
Comment Actions
@Bastien Montagne (mont29), do you think we shall get this into 2.91 as a bugfix/small improvement?
| source/blender/editors/curve/editcurve.c | ||
|---|---|---|
| 5701 | The ED_curve_nurb_select_count(v3d, nu) < nu->pntsu seems redundant to me. | |
Comment Actions
@Sergey Sharybin (sergey) I'd rather not add even more to 2.91.1, this one already have way too many commits listed, most of them not even being obvious serious/important fixes...
Comment Actions
@Bastien Montagne (mont29), Sorry, I got numbering wrong. Surely this is not for 2.91.1 as this is not a fix for a regression. What i meant is: 2.92 (which is scheduled to branch soon) or 2.93? In another words, do you find this change fine for bcon2?
Comment Actions
@Sergey Sharybin (sergey) Ah ok, yes, this totally fits into BCon2 definition for me, so sure it is still valid for 2.92.
Comment Actions
@Sergey Sharybin (sergey) : Thank you for your review. I tested it once again and I don't think the code is redundant. You won't be able to extrude a surface. You will one extrude if you select a single point. This behaves then like a regular curve. Please see my comment.
| source/blender/editors/curve/editcurve.c | ||
|---|---|---|
| 5701 | No, this is not redundant because if you remove this part of the if statement, you will forever move all the points of the surface nurbs curve and you won't be able to extrude a surface. In other words, the default nurbs surface curve will always behave like a curve nurbs curve. | |