Page MenuHome
Differential D9940

UI: Asset Browser Object Thumbnails
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Dec 28 2020, 6:40 PM.
Tags
Subscribers
Dalai Felinto (dfelinto)
Julian Eisel (Severin)
Pablo Vazquez (pablovazquez)
Tokens
"Love" token, awarded by wilBr."Love" token, awarded by Stig."Love" token, awarded by Brandon777."Love" token, awarded by lcs_cavalheiro."Like" token, awarded by rboxman."Burninate" token, awarded by Maged_afra."Love" token, awarded by franMarz."Love" token, awarded by dulrich."Like" token, awarded by deadpin.

Details

Reviewers
Pablo Vazquez (pablovazquez)
Julian Eisel (Severin)
Group Reviewers
User Interface
Commits
rBecc7a837982e: UI: Object Thumbnails Orientation Change
Summary

This makes small changes to the Asset Browser thumbnails for objects. A slight change in the orientation helps gauge the shapes, especially when axis aligned.

On the following capture, the top shows how they look now, with axis aligned objects either not showing shape well or not at all. The bottom shows how it looks after this patch is applied.

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Dec 28 2020, 6:40 PM
Harley Acheson (harley) created this revision.
Harley Acheson (harley) updated this revision to Diff 32317.Dec 29 2020, 1:15 AM

Camera focal length changed to 85mm, a nice setting for close portraiture. The old wider lens would have been a bit too distorting of some objects, like human heads.

Harley Acheson (harley) edited the summary of this revision. (Show Details)Dec 29 2020, 1:16 AM
Pablo Vazquez (pablovazquez) accepted this revision as: Pablo Vazquez (pablovazquez).Dec 29 2020, 5:19 PM
Pablo Vazquez (pablovazquez) added a subscriber: Pablo Vazquez (pablovazquez).

Looks much nicer! +1 on the aesthetic side.

This revision is now accepted and ready to land.Dec 29 2020, 5:19 PM
Jesse Yurkovich (deadpin) awarded a token.Dec 30 2020, 1:59 AM
Daniel Ulrich (dulrich) awarded a token.Dec 30 2020, 6:18 AM
Fran Marz (franMarz) awarded a token.Jan 1 2021, 1:39 AM
Harley Acheson (harley) added a project: BF Blender (2.93).Jan 4 2021, 4:21 AM
Maged afra (Maged_afra) awarded a token.Jan 4 2021, 4:41 AM
Roger B (rboxman) awarded a token.Jan 15 2021, 9:50 AM
Hans Goudey (HooglyBoogly) mentioned this in T82704: Polish Preview Creation.Feb 6 2021, 1:29 AM
Leandro Cavalheiro (lcs_cavalheiro) awarded a token.Feb 7 2021, 6:04 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).Feb 24 2021, 6:02 PM

Could you separate the shading changes? The orientation changes seem fine, let's get that in. The shading changes I'm more unsure about, something to discuss further.

Harley Acheson (harley) updated this revision to Diff 34431.Feb 26 2021, 1:43 AM
Harley Acheson (harley) edited the summary of this revision. (Show Details)

Now only changing orientation, not the shading.

Brandon (Brandon777) awarded a token.Feb 26 2021, 7:31 PM
Dalai Felinto (dfelinto) added 1 blocking reviewer(s): User Interface.Mar 26 2021, 5:26 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

This patch has an approved status yet it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect that. This way the patch show as pending still.

This revision now requires review to proceed.Mar 26 2021, 5:26 PM
Julian Eisel (Severin) requested changes to this revision.Apr 30 2021, 8:55 PM

Would be great to get in. Just one little thing to fix.

source/blender/editors/render/render_preview.c
695

sizex and sizex are unused now.

This revision now requires changes to proceed.Apr 30 2021, 8:55 PM
Harley Acheson (harley) updated this revision to Diff 36695.May 1 2021, 12:41 AM

@Julian Eisel (Severin) - Would be great to get in.

I forgot about this one.

Just one little thing to fix.

Yes, completely missed that. Fixed. Thanks!

Stig Oskar (Stig) awarded a token.May 1 2021, 1:52 AM
Julian Eisel (Severin) accepted this revision.May 1 2021, 12:04 PM
This revision is now accepted and ready to land.May 1 2021, 12:04 PM
Closed by commit rBecc7a837982e: UI: Object Thumbnails Orientation Change (authored by Harley Acheson (harley)). · Explain WhyMay 1 2021, 6:16 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rBecc7a837982e: UI: Object Thumbnails Orientation Change.
Wilsimar (wilBr) awarded a token.May 1 2021, 6:49 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
render/
23 lines

Diff 36695

View Options

source/blender/editors/render/render_preview.c

Loading...