Differential D9950

Fix T84191: remove python API limits for Image.scale() width and height
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 29 2020, 1:23 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T84191: Image scale limit issue

Summary

Since the introduction in rB2c23bb838979, these were set to 10000 each.

This seems like an arbitrary limit (BKE_image_scale / IMB_scaleImBuf
dont seem to have limits and I couldnt spot similar size restrictions in
image relating functions), now match what we do for creating images
(rna_Main_images_new), use INT_MAX.

Diff Detail

Repository

rB Blender

Branch

T84191 (branched from master)

Build Status

Buildable 11910
Build 11910: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 29 2020, 1:23 PM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) added a project: Python API.Dec 29 2020, 1:24 PM

Harbormaster completed remote builds in B11910: Diff 32322.Dec 29 2020, 1:24 PM

Campbell Barton (campbellbarton) mentioned this in rB80e720ee4af4: Fix T84191: remove python API limits for Image.scale() dimensions.Jan 4 2021, 9:13 AM

Thanks, committed rB80e720ee4af4acff8f5fac768a9458e6e43a5cc0

This matches imbuf.new too.

This revision is now accepted and ready to land.Jan 4 2021, 9:13 AM

Campbell Barton (campbellbarton) closed this revision.Jan 4 2021, 9:13 AM

Valeri Barashkov (valera) awarded a token.Jan 5 2021, 3:55 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_image_api.c

4 lines

Diff 32322

View Options

source/blender/makesrna/intern/rna_image_api.c

Fix T84191: remove python API limits for Image.scale() width and heightClosedPublicActions