Page MenuHome

Fix T84031 initialize connectivity info of the base mesh before using Displacement Smear brush.
ClosedPublic

Authored by Greg Neumiller (rlneumiller) on Dec 30 2020, 3:05 AM.

Diff Detail

Repository
rB Blender
Branch
T84031 (branched from master)
Build Status
Buildable 11918
Build 11918: arc lint + arc unit

Event Timeline

Greg Neumiller (rlneumiller) requested review of this revision.Dec 30 2020, 3:05 AM
Pablo Dobarro (pablodp606) requested changes to this revision.Dec 30 2020, 11:02 PM

This is crashing because the connectivity info of the base mesh was not initialized yet. This tools always needs connectivity info, so it should be added to the list in sculpt_needs_connectivity_info.
The code of the tool can also run without multires enabled, but it won't do anything right now. The tool gets the limit surface by using the sculpt API, which is currently only implemented for multires (for meshes it always returns the same coordinate, so there is no displacement and nothing to smear). In the future there could be a way to cache a temporally limit surface for meshes without multires, so the tool should also work fine.

This revision now requires changes to proceed.Dec 30 2020, 11:02 PM
Greg Neumiller (rlneumiller) retitled this revision from Fix T8403 by exiting early if Multires has not been used to Fix T84031 by exiting early if Multires has not been used.Dec 31 2020, 3:23 AM

Removed my workaround and added proper fix as provided pablodp606 - Fix for T84031: initialize connectivity info of the base mesh before

This revision is now accepted and ready to land.Dec 31 2020, 6:20 PM
Greg Neumiller (rlneumiller) retitled this revision from Fix T84031 by exiting early if Multires has not been used to Fix T84031 initialize connectivity info of the base mesh before using Displacement Smear brush..Dec 31 2020, 6:38 PM