Page MenuHome
Differential D9973

Base stdosl_path on shader_path in OSL compilation
ClosedPublic
Actions

Authored by howetuft (howetuft) on Jan 2 2021, 9:32 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rC40235f89c5cc: Fix Cycles not taking into account CYCLES_SHADER_PATH for finding stdcycles.h
rB2cd091e9c709: Fix Cycles not taking into account CYCLES_SHADER_PATH for finding stdcycles.h
Summary

This would give a chance for CYCLES_SHADER_PATH to be taken into account when looking for 'stdcycles.h' in osl compilation.
(see path_get / path_specials in util_path.cpp)

Diff Detail

Event Timeline

howetuft (howetuft) requested review of this revision.Jan 2 2021, 9:32 AM
howetuft (howetuft) created this revision.
Harbormaster completed remote builds in B11946: Diff 32377.Jan 2 2021, 9:32 AM
howetuft (howetuft) edited the summary of this revision. (Show Details)Jan 2 2021, 2:18 PM
howetuft (howetuft) added a reviewer: Brecht Van Lommel (brecht).
howetuft (howetuft) added a project: Render & Cycles.
Brecht Van Lommel (brecht) accepted this revision.Jan 12 2021, 2:55 PM

Thanks!

This revision is now accepted and ready to land.Jan 12 2021, 2:55 PM
Closed by commit rB2cd091e9c709: Fix Cycles not taking into account CYCLES_SHADER_PATH for finding stdcycles.h (authored by Brecht Van Lommel (brecht)). · Explain WhyJan 13 2021, 12:13 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB2cd091e9c709: Fix Cycles not taking into account CYCLES_SHADER_PATH for finding stdcycles.h.
howetuft (howetuft) added a comment.Jan 16 2021, 2:31 PM

Hello,

Thank you very much for having merged this revision!

However, would it possible to merge it in rC (cycles standalone) as well? I use rC branch a lot... Thanks in advance!

Stefan Werner (swerner) added a commit: rC40235f89c5cc: Fix Cycles not taking into account CYCLES_SHADER_PATH for finding stdcycles.h.Mar 1 2021, 2:20 AM

Revision Contents
Changeset List

PathSize
src/
render/
2 lines

Diff 32377

View Options

src/render/osl.cpp

Loading...