Page MenuHome
Differential D9981

Add high frequency mouse input for Windows.
ClosedPublic
Actions

Authored by Nicholas Rishel (nicholas_rishel) on Jan 4 2021, 7:38 AM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Brecht Van Lommel (brecht)
Commits
rBd5c59913de95: Fix T81211 Add high frequency mouse input for Windows.
Summary

Send mouse move event instead of moving cursor.

SetCursorPos does not reliably move the mouse when it is leaving the
window quickly.

Diff Detail

Repository
rB Blender
Branch
MouseMovePointsEx (branched from master)
Build Status
Buildable 11959
Build 11959: arc lint + arc unit

Event Timeline

Nicholas Rishel (nicholas_rishel) requested review of this revision.Jan 4 2021, 7:38 AM
Nicholas Rishel (nicholas_rishel) created this revision.
Harbormaster completed remote builds in B11959: Diff 32403.Jan 4 2021, 7:38 AM
Nicholas Rishel (nicholas_rishel) added reviewers: Ray Molenkamp (LazyDodo), Brecht Van Lommel (brecht).Jan 4 2021, 7:42 AM
Nicholas Rishel (nicholas_rishel) updated this revision to Diff 32404.Jan 4 2021, 7:59 AM

Fixup.

Harbormaster completed remote builds in B11960: Diff 32404.Jan 4 2021, 7:59 AM
Nicholas Rishel (nicholas_rishel) updated this revision to Diff 32405.Jan 4 2021, 8:17 AM

Remove vestigial tablet handling code from processCursorEvent.

Harbormaster completed remote builds in B11961: Diff 32405.Jan 4 2021, 8:17 AM
Nicholas Rishel (nicholas_rishel) mentioned this in T75528: Continuous Grab occasionally jumping when going across region border at high mouse polling rate.Jan 4 2021, 8:25 AM
Nicholas Rishel (nicholas_rishel) updated this revision to Diff 32407.Jan 4 2021, 8:49 AM
  • Fix T81211: Add high frequency mouse input for Windows.
  • Send mouse move event instead of moving cursor.
Harbormaster completed remote builds in B11963: Diff 32407.Jan 4 2021, 8:49 AM
Nicholas Rishel (nicholas_rishel) added a project: BF Blender (2.93).Jan 4 2021, 10:05 PM
Nicholas Rishel (nicholas_rishel) updated this revision to Diff 32433.Jan 4 2021, 10:20 PM
  • Fix T81211: Add high frequency mouse input for Windows.
  • Send mouse move event instead of moving cursor.
Harbormaster completed remote builds in B11980: Diff 32433.Jan 4 2021, 10:20 PM
WMROssi (Anubis) awarded a token.Jan 6 2021, 8:57 PM
Brecht Van Lommel (brecht) accepted this revision.Jan 11 2021, 6:03 PM

I think this is fine still in bcon2. If it causes problems it can be reverted.

This revision is now accepted and ready to land.Jan 11 2021, 6:03 PM
Closed by commit rBd5c59913de95: Fix T81211 Add high frequency mouse input for Windows. (authored by Nicholas Rishel (nicholas_rishel)). · Explain WhyJan 11 2021, 8:41 PM
This revision was automatically updated to reflect the committed changes.
Nicholas Rishel (nicholas_rishel) added a commit: rBd5c59913de95: Fix T81211 Add high frequency mouse input for Windows..
Nicholas Rishel (nicholas_rishel) removed a project: BF Blender (2.93).Jan 11 2021, 8:57 PM
Samuel Sebastian Tekrenius (AgentSam) added a subscriber: Samuel Sebastian Tekrenius (AgentSam).Apr 30 2021, 8:38 PM

Revision Contents
Changeset List

PathSize
intern/
ghost/
intern/
18 lines
137 lines

Diff 32403

View Options

intern/ghost/intern/GHOST_SystemWin32.h

Loading...
View Options

intern/ghost/intern/GHOST_SystemWin32.cpp

Loading...