Fix T84260: NURBS edit mode lines not showing
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Jan 4 2021, 1:14 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T84260: NURBS Surface Edit Mode: Spline Cage of Unselected Surface Is Not Fully Rendered

Commits

rB09c1cb8a17e4: Fix T84260: NURBS edit mode lines not showing

Summary

When in edit mode, the edit lines for de-selected surfaces did not
show up.

The bug was caused by the is_gpencil bool which reused another flag.
Both grease pencil and nurbs surfaces use the edit_curve_handle shader.
A dedicated flag was added to make sure the is_gpencil bool is
set correctly.

Diff Detail

Repository: rB Blender

Event Timeline

Falk David (filedescriptor) requested review of this revision.Jan 4 2021, 1:14 PM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B11970: Diff 32415.Jan 4 2021, 1:14 PM

Falk David (filedescriptor) added a project: EEVEE & Viewport.Jan 4 2021, 1:16 PM

Falk David (filedescriptor) added a subscriber: Clément Foucault (fclem).

Falk David (filedescriptor) added a reviewer: Clément Foucault (fclem).Jan 4 2021, 1:28 PM

Falk David (filedescriptor) removed a subscriber: Clément Foucault (fclem).

I request minor changes that can be done at the moment of commiting.

The patch looks good to me.

source/blender/draw/intern/draw_cache_impl.h
232–234	I would keep the previous comment. But also state why the following value is above the 8bit limit. `/* NOTE: Grease pencil edit curve use another type of data format that allows for this value */`
source/blender/draw/intern/draw_cache_impl_gpencil.c
765–766	This comment can be removed.
source/blender/draw/intern/shaders/common_globals_lib.glsl
147	Nitpick: Move this on line 128.