Page MenuHome

Fix T84382: Geometry Nodes: Vertex group attributes are removed
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jan 4 2021, 9:33 PM.

Details

Summary

In the report, the geometry is copied because it has two users and the
final join node needs to write to it. The join node also happens to
remove attributes apparently, because it exposed a mistake in the "copy"
method of the MeshComponent class. The copy is supposed to be
a deep copy, but the vertex group name map was not duplicated.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jan 4 2021, 9:33 PM
Hans Goudey (HooglyBoogly) created this revision.

Not sure if it applies here, but in general we can't be sure that if an attribute goes into geometry nodes as a vertext group, that it also comes out as a vertex group. E.g. currently, the Join node converts vertex groups to custom data layers. That can be changed, but ideally this should not have any impact on users. Unfortunately, it does currently, because only vertex groups can be previewed...

This revision is now accepted and ready to land.Jan 4 2021, 9:49 PM

Not sure if it applies here, but in general we can't be sure that if an attribute goes into geometry nodes as a vertext group, that it also comes out as a vertex group. E.g. currently, the Join node converts vertex groups to custom data layers. That can be changed, but ideally this should not have any impact on users. Unfortunately, it does currently, because only vertex groups can be previewed...

Maybe (hopefully?) vertex groups will eventually just be regular float attributes. I don't think that problem applies here anyway.