Page MenuHome

Geometry Nodes: Multiple dynamic sockets for the Join Geometry Node.
AbandonedPublic

Authored by Fabian Schempp (fabian_schempp) on Jan 4 2021, 11:15 PM.

Details

Reviewers
None
Summary

This patch adds the ability to join multiple Geometry Sets to the Join Geometry Node.

Diff Detail

Repository
rB Blender
Branch
geometry_nodes_multi_join (branched from master)
Build Status
Buildable 11982
Build 11982: arc lint + arc unit

Event Timeline

Fabian Schempp (fabian_schempp) requested review of this revision.Jan 4 2021, 11:15 PM
Fabian Schempp (fabian_schempp) created this revision.
FabianSchempp (FabianSchempp) edited the summary of this revision. (Show Details)
Kenzie (kenziemac130) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc
24–37

I disagree with this implementation. It is very likely that in real use someone would likely try to join upwards of dozens of geometry variants manually (I would disagree with this approach but nevertheless this would end up being a bug report). The implementation should be able to support any number of joins should the user decide to do so. More nodes than the join node will likely need to support this type of variable input as well. This solution needs to be more robust to be used elsewhere.

This implementation has been deprecated. Please See https://developer.blender.org/D10067

source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc
24–37

This implementation has been deprecated. I talked with Hans Goudey. about this and he said, that there should be a new socket type to handle this: Please See https://developer.blender.org/D10067

Closing this, since we have the multi-socket now.