Scene strips can't be prefetched and seq_prefetch_do_skip_frame()
should check if scene strip is in timeline. But it did not recurse into
meta strips, which resulted in crash.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- master
- Build Status
Buildable 11988 Build 11988: arc lint + arc unit
Event Timeline
Comment Actions
Scene strips can't be prefetched
Is it explained somewhere why scene strips are so special?
This function did not recurse into meta strips, which resulted in crash.
This sounds unrelated to the scene strip case. Are both changes required to fix crash or can they be split into 2 separate ocmmits?
Comment Actions
Not really directly, in seq_render_scene_strip() it is kinda explained, that rendering 3D scene requires main lock or setting up render job that doesn't have API to do openGL renders which can be used for sequencer.
I will add such comment.
This function did not recurse into meta strips, which resulted in crash.
This sounds unrelated to the scene strip case. Are both changes required to fix crash or can they be split into 2 separate ocmmits?
There is only one issue being solved - it crashed, because scene strip was inside of meta strip. Updated commit msg to make this more clear.