Page MenuHome
Differential D999

Outliner [experimental]: added two ops to (a) scroll when hitting region borders, (b) open up tree elements when hitting 'plus' icon
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 16 2015, 6:22 PM.

Details

Reviewers
None
Summary

This patch adds two ops in the outliner:

  • scroll when hitting upper/lower region borders
  • open up tree elements when dragging over 'plus' icon

implementation is more of a hack (functionality is in poll() function...) I am just dropping this here as a proof of concept. Will work on better implementation if desired.
Also: atm. the openup action will happen immediately (should better use a timer -- 1sec or so...)

(this is part of more work on the outliner, I've split this up in smaller pieces for review now...)

Let me know what you think...

Diff Detail

Event Timeline

Philipp Oeser (lichtwerk) updated this revision to Diff 3170.Jan 16 2015, 6:22 PM
Philipp Oeser (lichtwerk) retitled this revision from to Outliner [experimental]: added two ops to (a) scroll when hitting region borders, (b) open up tree elements when hitting 'plus' icon.
Philipp Oeser (lichtwerk) updated this object.
Philipp Oeser (lichtwerk) mentioned this in T43282: OutlinerLove: a couple of goodies for the outliner.Jan 16 2015, 6:41 PM
Campbell Barton (campbellbarton) requested changes to this revision.Jan 21 2015, 2:28 PM
Campbell Barton (campbellbarton) added a reviewer: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).
  • Open on drag seems like its generally useful.
  • Scrolling needs to use a timer, currently you have to wave your mouse about.

Also, not sure its ideal to have these as operators, would be interested to see if it could be done lower level in ourliner code, but it may well be too complicated.

This revision now requires changes to proceed.Jan 21 2015, 2:28 PM
Philipp Oeser (lichtwerk) added a comment.Jan 21 2015, 4:27 PM

agree. lets see if I can come up with something...

Philipp Oeser (lichtwerk) updated this revision to Diff 3664.Mar 2 2015, 5:27 PM
Philipp Oeser (lichtwerk) edited edge metadata.

Came up with bit more general solution for the scrolling part (e.g. also scrolls the NodeEditor and PropertyEditor now... could basically be any Editor)...
What do you think?

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Mar 5 2015, 9:50 AM

Do you mind updating this patch to the latest master since it can't be cleanly applied.

Philipp Oeser (lichtwerk) updated this revision to Diff 3678.Mar 5 2015, 1:09 PM
Philipp Oeser (lichtwerk) edited edge metadata.

sorry about this. should apply to master now (not sure why git diff was hating that line...)

Philipp Oeser (lichtwerk) added a comment.Mar 12 2015, 12:13 PM

@Sergey Sharybin (sergey): is this still being considered?

Campbell Barton (campbellbarton) added a comment.Apr 22 2015, 4:22 PM

Patch isn't applying,

Think this should still use a timer.

Thinking we could make this a ARegionType callback. art->drag_scroll, art->drag_hover or so.

This way any region can scroll while dragging.

Campbell Barton (campbellbarton) removed a reviewer: Campbell Barton (campbellbarton).Aug 11 2016, 6:17 AM
Campbell Barton (campbellbarton) removed a subscriber: Campbell Barton (campbellbarton).
Philipp Oeser (lichtwerk) abandoned this revision.Aug 16 2021, 3:18 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
14 lines
windowmanager/
intern/
29 lines
2 lines
3 lines

Diff 3678

View Options

source/blender/editors/interface/view2d_ops.c

Loading...
View Options

source/blender/windowmanager/intern/wm_dragdrop.c

Loading...
View Options

source/blender/windowmanager/intern/wm_event_system.c

Loading...
View Options

source/blender/windowmanager/wm_event_system.h

Loading...