Page MenuHome
Create Task
Maniphest T18115

Action Editor -> Ctrl+L crashes Blender -- small edittime patch to prevent that
Closed, ArchivedPublicPATCH
Actions

Description

Just after starting up Blender, go to Action Editor and hit Ctrl+L - Blender crashes because of null pointer reference in edittime.c:191:

for (marker= markers->first; marker; marker= marker->next) {

That's because there is NULL assigned to markers pointer few lines before.
So I've changed all for loops with such line:

for (marker= (markers ? markers->first : NULL); marker; marker= marker->next) {

And now it works.

Event Timeline

Sebastian Kochman (raiq) edited a custom field.Dec 22 2008, 11:32 AM
Sebastian Kochman (raiq) attached 1 file(s): F7065: edittime_patch.txt.
Joseph Eagar (joeedh) added a comment.Dec 22 2008, 11:38 AM

assigning to joshua.

Joshua Leung (aligorith) added a comment.Dec 22 2008, 11:55 AM

Hi,

Although this fixes the code for this particular part of the code, it does not solve the issues in numerous other places (patch only covers transform markers). Also, this fix makes the code less readable (too much going on in the line calling the for...loop).

Thanks for attempting to fix this problem anyway.

Regards,
Joshua

Joshua Leung (aligorith) changed the task status from Unknown Status to Unknown Status.Dec 22 2008, 11:55 AM