This patch adds a popup list to the camera display properties where different image composition guides can be selected. The following guides are implemented:
- rule of thirds
- golden mean
- golden triangle
- diagonals
The feature has been requested in the forum (http://www.blender.org/forum/viewtopic.php?t=14911&highlight=composition) a while ago.
Screenshot for rule of thirds view included.
Description
Description
Event Timeline
Comment Actions
Just a quick review of the patch:
In general, it looks like you've covered all the parts that need to be implemented for this. Whether this gets into trunk in its current form, or with some functional changes I'll leave to others who are more familiar with such work.
However, there are a few other matters I'd recommend you clean up in your patch, mainly regarding formatting, etc.
- Use tabs not spaces.
- No extra spaces after opening braces {,(,[
- Use shorter names for the names in the second column of the EnumPropertyItem defines. i.e. "THIRDS" instead of "CG_TYPE_THIRDS", since these defines are used from the PY-API and should be kept shorter since the context is generally clear there (so prefixes become irrelevant)
Relevant links:
- http://wiki.blender.org/index.php/BlenderDev/Blender2.5/NamingConvention (for comments 2 and 3)
- http://wiki.blender.org/index.php/Dev:Py/Blender2.5/Layouts/Guidelines (for UI/Py code)
Comment Actions
Reformatted as requested. Fixed layout to greying out instead of hiding.
See compo_guides_formatted.patch
Comment Actions
I think this does have some uses, although back when I last discussed this with Matt, he disagreed.
Comment Actions
Hi, I was looking to implement this my self and josh pointed me to this patch. It's precisely what I was looking for
I have updated it for r36331 and made some small changes
Comment Actions
This looks great! I hacked my own blender to display thirds instead of the title safe area, but this looks far more useful. +1 from me.
Comment Actions
Hi, trying to update the status of the patch tracker. Please respond if this patch is still viable/useful and needs review or if it can be closed.
Comment Actions
Sorry for the delay. Reply by mail bounced with error.
Anyway: The feature is already present (at least in the svn version), with the implementation by somebody else. You can close this particular patch.
Comment Actions
Camera Composition Guides is lacking of underlined letter shortcut, can this be added?
Like the next image, the one on the right shows the underlined shortcut.:
http://img89.imageshack.us/img89/8357/25b0.png
Should I add this to bug report?