Page MenuHome

Adding multisample support to Win32 Ghost
Closed, ArchivedPublicPATCH

Description

The summary pretty much says it. This patch adds multisample (anti-aliasing) support to the Win32 specific parts of Ghost. Now, the only platform we're missing is X11.

Event Timeline

It seems correct to me as far as ghost features are concerned, though Win32 seems to make things complex...

Nathan, I've forwarded this patch to you, as you'll be more expert to review these Win32 specifics, as Ghost Win32 owner.

Tested the patch, thx for it :)
Vista x32, Gefore 8600GT.

-Sub Windows having issues (like User Preferences and "New Window" Render.)
Text and Icons are screwed up. (see Bug_subwindow.jpg)

-Maybe not directely releated but it looks as the "OpenGL Viewport Render" feature doesnt't use the new sampling, the render looks more aliased than what you see in the 3D Window itself.

Apart from that it works nice, didn't found any performance issues.

How did you enable the AA? by default the multisample samples is set to 0, which disables it. This can be changed in wm_window.c, or by updating to a newer revision and using the user preferences. Also, the AA should only be affecting the 3dview, unless you added in more glEnable(GL_MULTISAMPLE_ARB) calls.

I applied the patch to latest SVN of course (with User Preferences)
Can't explain the problem with text/icons myself, but it's there. ;-)

Thomas, I'm now able to reproduce the bug and I'm working to fix the issue.

Okay, issue fixed. I've uploaded a new patch, ghost_multisample2.patch.

Nathan Letwory (jesterking) changed the task status from Unknown Status to Unknown Status.Jan 13 2010, 8:38 PM