Page MenuHome
Create Task
Maniphest T26721

Make loopcut, knife etc. themeable
Closed, ArchivedPublicTO DO
Actions

Description

This patch adds a theme color for loopcut selection.

I didn't want to mess with the versions so the do_versions function only checks for versionfile < 257.
I guess the reviewer should decide what to do.

Event Timeline

Sergej Reich (sergof) edited a custom field.Apr 1 2011, 7:41 PM
Sergej Reich (sergof) attached 1 file(s): F16486: loopcut_theme.patch.
Thomas Dinges (dingto) added a comment.Apr 1 2013, 12:23 PM

Hey,
do you still think this should go in? :)

Sergej Reich (sergof) added a comment.Apr 18 2013, 3:43 PM

Sorry, somehow missed this.

Well, since pretty much everyhing in blender has a theme color I think loopcut should have it too.
Not sure who usually decides there things but it would be up to them.

This patch won't apply to current svn of course.

Bastien Montagne (mont29) renamed this task from Make loopcut themeable to Make loopcut, knife etc. themeable.Sep 23 2014, 1:00 PM
Bastien Montagne (mont29) claimed this task.
Bastien Montagne (mont29) edited a custom field.
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Will handle this after 2.72 release (knife could also use themeable colors, at least).

Could also be a good occasion to harmonize those tools' colors!

Jonathan Williamson (carter2422) added a subscriber: Jonathan Williamson (carter2422).Sep 23 2014, 9:36 PM

I'm not too thrilled by the idea of adding yet more theme colors. I'd much rather see us consolidate theme colors to be much more manageable by using groups of colors. For example, Mesh Tool colors, which might include color states for:

  1. Active Modal Element (such as current knife cut)
  2. In-active Modal Element (such as previous knife cuts within the same modal)
  3. Etc
  4. Etc

Creating custom themes right now is an absolutely daunting task. Unnecessarily so. With some thoughtful planning we ought to be able to consolidate many of the colors per editor to make them much, much more manageable. Creating a theme right now involves an awful lot of repetitive work, since we often set the same colors for many different operations across different editors.

ronan ducluzeau (zeauro) added a subscriber: ronan ducluzeau (zeauro).Sep 24 2014, 4:18 PM

carter2422 is right.
Actually, not only loopcut and knife are concerned but also vertex/edge slide.

Bastien Montagne (mont29) added a comment.Sep 26 2014, 4:08 PM

Actually, that was my idea when I said « Could also be a good occasion to harmonize those tools' colors! » - to only have a set of colours reused by all those tools. ;)

Jonathan Williamson (carter2422) added a comment.Sep 26 2014, 4:13 PM

Ah excellent! I didn't catch that @Bastien Montagne (mont29) :)

Julian Eisel (Severin) changed the task status from Unknown Status to Archived.Feb 18 2015, 4:47 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Rejecting for now, as the decision was made to not allow any new theme options for now and the request for reorganizing those type of theme colors needs a bit more work beyond the scope of this patch.