Page MenuHome

Redundant applying of SetNetworkDevice
Closed, ArchivedPublicPATCH

Description

Hi,

SetNetworkDevice is used redundantly in BL_KetsjiEmbedStart.cpp and GPG_Application.cpp

Regards,
lordloki

Event Timeline

How can I verify this is not needed, can you give some extra info please?

Jorge, can you please give more infos as Campbell asked for? Thanks.

Sorry, i didn't see the first petition.

In the set devices part, the Network device is set almost twice consecutively.

// set the devices
ketsjiengine->SetKeyboardDevice(keyboarddevice);
ketsjiengine->SetMouseDevice(mousedevice);
ketsjiengine->SetNetworkDevice(networkdevice); /* FIRST TIME */
ketsjiengine->SetCanvas(canvas);
ketsjiengine->SetRenderTools(rendertools);
ketsjiengine->SetRasterizer(rasterizer);
ketsjiengine->SetNetworkDevice(networkdevice); /* SECOND TIME */
ketsjiengine->SetUseFixedTime(usefixed);
ketsjiengine->SetTimingDisplay(frameRate, profile, properties);

And the same for GPG_Application file.
I realize that my C++ knowledge is not very good but i think that it is not necessary. In fact, I'm reusing for an external_networkdevice (adding net support to the gameengine) and i haven't had problems.

Regards,
Jorge

Campbell Barton (campbellbarton) changed the task status from Unknown Status to Unknown Status.Aug 21 2011, 11:18 PM