Page MenuHome
Create Task
Maniphest T28496

BMesh: fix 28492
Closed, ArchivedPublicPATCH
Actions

Description

Simplest possible patch

Event Timeline

Andrew Wiggin (ender79) edited a custom field.Sep 3 2011, 4:03 PM
Andrew Wiggin (ender79) attached 1 file(s): F15561: bmesh.fix28492.review.1.patch.
Andrew Wiggin (ender79) attached 1 file(s): F15563: bmesh.fix28492.review.2.patch.Sep 4 2011, 4:12 PM

Howard found that this only fixes one issue causing this bug, but there is another issue that manifests itself if you are in vertex select mode (instead of edge select mode) when you are selecting / deselecting edge loops.

This new patch should fix both. It does so by disabling some functionality in BM_Select_Edge and BM_Select_Face which was commented as not being 100% reliable. Turns out, there were at least two different things it was breaking.

Howard Trickey (howardt) added a comment.Sep 4 2011, 5:02 PM

I reviewed and submitted this patch. Review at http://codereview.appspot.com/4975056/

Andrew Wiggin (ender79) changed the task status from Unknown Status to Unknown Status.Sep 13 2011, 4:03 PM