Page MenuHome
Create Task
Maniphest T28537

BMesh: fix for second issue in 28492 (edge ring deselct not working)
Closed, ArchivedPublicPATCH
Actions

Description

The function invoked for the MESH_OT_edgering_select operator did not support deselect.

Rather than fixing it there, this patch changes the implementation of the MESH_OT_edgering_select operator to use the common loop select/deselect code in mouse_mesh_loop which already supported rings, and deselect.

Event Timeline

Andrew Wiggin (ender79) edited a custom field.Sep 7 2011, 9:03 AM
Andrew Wiggin (ender79) attached 1 file(s): F15663: bmesh.fix28492-part2-edgeringextend.review.2.patch.
Andrew Wiggin (ender79) added a comment.Sep 7 2011, 9:06 AM

Note I also considered just removing the MESH_OT_edgering_select operator, and changing ctrl+alt+RMB and shift+ctrl+alt+RMB to call with ring=1. This gets the same effect from the UI, but could break scripts that used the mesh.edgering_select operator...

If this way would preferred, let me know, I could put that patch up instead.

Howard Trickey (howardt) added a comment.Sep 7 2011, 10:35 AM

Submitted, rev 40001.

Campbell Barton (campbellbarton) changed the task status from Unknown Status to Unknown Status.Sep 8 2011, 12:07 PM