Page MenuHome
Create Task
Maniphest T28552

Fix for 28551
Closed, ArchivedPublicPATCH
Actions

Description

Fixes several places that were calculating normals for 3d geometry using 2d math functions, including select similar which is broken as shown in bug 28551.

Event Timeline

Andrew Wiggin (ender79) edited a custom field.Sep 7 2011, 4:48 PM
Andrew Wiggin (ender79) attached 1 file(s): F15711: trunk.bug28551.review.1.patch.
Sergey Sharybin (sergey) added a comment.Sep 7 2011, 5:18 PM

Commited to rev40017

Sergey Sharybin (sergey) changed the task status from Unknown Status to Unknown Status.Sep 7 2011, 5:18 PM
Andrew Wiggin (ender79) attached 1 file(s): F15712: trunk.bug28551-extra.review.1.patch.Sep 9 2011, 3:53 PM

Attaching another patch with one of my changes that was missed in the merge between my patch and your (extremely responsive =D) fix before you saw my patch. This one affects selecting similar edges based on face angles.

Sergey Sharybin (sergey) added a comment.Sep 9 2011, 4:05 PM

Yeah, most probably was lost when was doing merge, pardon. Patch is commited now :)