Page MenuHome
Create Task
Maniphest T31678

Fix for properties having spaces in names when using the property sensor with interval as a evaluation.
Closed, ResolvedPublicPATCH
Actions

Description

Patch for: T31122

The property sensor will not activate when using properties that contain spaces or other operator characters in the name when using interval as the evaluation mode. This was due to the sensor constructing an expression string containing the properties name and trying to evaluate it.

Changed the expression construction to use a reference to the property instead of it's name.

Event Timeline

Jay Parker (battery) edited a custom field.Jun 2 2012, 7:35 PM
Jay Parker (battery) attached 1 file(s): F20295: PropertySensorFix.patch.
Mitchell Stokes (moguri) added a comment.Jul 25 2012, 11:22 AM

Thanks for the patch. However, I implemented a fix for this prior to finding this patch (I guess I should check the patch tracker more often!). This patch might still be useful if the method I used breaks (I ripped out a lot of the expression parsing code and did simple range checks). But, for the time being, I'm going to close this.

Mitchell Stokes (moguri) changed the task status from Unknown Status to Resolved.Jul 25 2012, 11:22 AM