Page MenuHome
Create Task
Maniphest T31929

VSE crash with relative paths and rebuilding proxies
Closed, ResolvedPublic
Actions

Description

when manually assigning a relative path like "//proxies/" to a strips "Proxy Custom Directory" --> sequencer will crash once generating/rebuilding such a proxy.

I've attached a simple example demonstrating this. Just open the blend and [Menu "Strip>Rebuild Proxy and Timecode Indices"].

I've also attached a patch that solves this by doing an BLI_path_abs() on the index_dir before feeding it to the rebuild_context.
(as usual there might be a better way to do this :) )

I've also attached a backtrace and my system-info.txt

Event Timeline

Philipp Oeser (lichtwerk) edited a custom field.Jun 25 2012, 3:51 PM
Philipp Oeser (lichtwerk) attached 1 file(s): F21359: VSEProxies_relative_path_crash.tar.gz.
Philipp Oeser (lichtwerk) attached 1 file(s): F21362: backtrace.
Philipp Oeser (lichtwerk) attached 1 file(s): F21363: svn_diff_sequencer.diff.
Philipp Oeser (lichtwerk) attached 1 file(s): F21364: system-info.txt.
Philipp Oeser (lichtwerk) added a comment.Jun 25 2012, 5:19 PM

Bah, in order to also PLAYBACK the proxy (Sequencer NPanel> ViewSettings> Proxy Render Size) there seems to be a better place to do BLI_path_abs()
Attached a v02 of the patch that should do the trick for both generating and playback

Philipp Oeser (lichtwerk) attached 1 file(s): F21365: svn_diff_sequencer_v02.diff.Jun 25 2012, 5:19 PM
Sergey Sharybin (sergey) added a comment.Jun 28 2012, 10:00 AM

Fixed in svn rev48360 in a bit different way.
Thanks for the report, closing.

Sergey Sharybin (sergey) changed the task status from Unknown Status to Resolved.Jun 28 2012, 10:00 AM
Philipp Oeser (lichtwerk) added a comment.Jun 28 2012, 10:20 AM

Thanx, Sergey!

I dont get "in a bit different way" though (this is pretty much my v02 of the patch, no? - except for the variable name and the length of the strncpy, which doesnt make a difference here, right?)