Page MenuHome
Create Task
Maniphest T32212

Fix r49225 (BOOST_VERSION isn't set!)
Closed, ResolvedPublicPATCH
Actions

Description

So it started with my patch: http://projects.blender.org/tracker/index.php?func=detail&aid=32074&group_id=9&atid=127

But apparently people still use ancient distros and thus r49225 was committed. However, while checking against BOOST_VERSION, it never actually is set! My patch fixes that and should make everyone happy.

Event Timeline

Sven-Hendrik Haase (svenstaro) edited a custom field.Jul 29 2012, 6:29 AM
Sven-Hendrik Haase (svenstaro) attached 1 file(s): F18449: make-this-actually-work.patch.
Shinsuke Irie (irie) added a comment.Jul 29 2012, 11:53 AM

I don't know if your patch is really necessary because r49225 can be built with Boost 1.42 on Ubuntu 11.04, but explicitly including boost/version.hpp is good idea.

Shinsuke Irie (irie) added a comment.Jul 29 2012, 12:17 PM

Ahh, BOOST_FILESYSTEM_VERSION will be set appropriately in boost/filesystem.hpp, so the build goes well on older system though the following code makes no sense:

#if (BOOST_VERSION < 104400)
# define BOOST_FILESYSTEM_VERSION 2
#endif

Another solution is to remove the above code.

Sven-Hendrik Haase (svenstaro) added a comment.Jul 29 2012, 1:37 PM

It cannot be built on recent Boost versions, that is the problem. The macro is never expanded.

Lukas Tönne (lukastoenne) added a comment.Jul 29 2012, 3:53 PM

Congratulations! Your patch has been committed to the official
Blender SVN Tree!

Lukas Tönne (lukastoenne) changed the task status from Unknown Status to Resolved.Jul 29 2012, 3:53 PM