Page MenuHome
Create Task
Maniphest T37585

Move default theme and keymap to python preset files
Closed, ArchivedPublicTO DO
Actions

Description

If other developers agree, this would make it quite a bit easier to change the defaults and keep the various themes and keymaps in sync when making changes, otherwise changes get made in one place but not the other.

It is a fairly big change so would like to get some feedback from other developers on this. Some notes:

  • If you add any operator with shortcut key, you now have to edit a python file (kind of already the case for menus anyway)
  • Some things like timers are in keymap as well now and are critical to Blender function. We can leave those either in C or move them out of keymaps, where they do not really belong in my opinion.
  • I need to look into how this affects startup performance.

Event Timeline

Brecht Van Lommel (brecht) created this task.Nov 22 2013, 7:37 PM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) raised the priority of this task from to High.
Brecht Van Lommel (brecht) updated the task description. (Show Details)
Brecht Van Lommel (brecht) added a project: User Interface.
Brecht Van Lommel (brecht) edited a custom field.
Brecht Van Lommel (brecht) updated the task description. (Show Details)
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).
Jonathan Williamson (carter2422) added a subscriber: Jonathan Williamson (carter2422).Nov 22 2013, 7:39 PM
Jonathan Williamson (carter2422) added a comment.Nov 24 2013, 8:12 PM

I'm going to wait on committing changes for T37419 until this one is completed or determined.

Scott Petrovic (scottpetrovic) added a subscriber: Scott Petrovic (scottpetrovic).Dec 8 2013, 2:35 PM

This is a good idea. I didn't even know this information was stored twice.

Joshua Leung (aligorith) added a subscriber: Joshua Leung (aligorith).Dec 11 2013, 12:48 AM

A few questions:

  1. How will this affect things like version patching for theme files?
  2. Will these keymap changes affect the "builtin" keymaps (i.e. those like ED_KEYMAP_FRAMES, ED_KEYMAP_UI, etc.)?
  3. Does this cover other user preferences as well?
  4. I'm curious what the startup performance impacts are :)
Brecht Van Lommel (brecht) added a comment.Dec 11 2013, 1:17 AM

How will this affect things like version patching for theme files?

You'd still need to do version patching when adding new theme colors.

Will these keymap changes affect the "builtin" keymaps (i.e. those like ED_KEYMAP_FRAMES, ED_KEYMAP_UI, etc.)?

I think so, as far as I know ED_KEYMAP_FRAMES and others are just convenient flags to add a named keymap like "Frames", and the flags can stay. I don't see a reason to give these special treatment.

Does this cover other user preferences as well?

No.

DataDay (DataDay) added a subscriber: DataDay (DataDay).Dec 13 2013, 9:54 PM
Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).Dec 16 2013, 3:50 PM
Brecht Van Lommel (brecht) added a project: Blender 2.70.Jan 4 2014, 4:31 AM
Brecht Van Lommel (brecht) lowered the priority of this task from High to Normal.Feb 9 2014, 4:13 PM
Brecht Van Lommel (brecht) removed a project: Blender 2.70.
Bastien Montagne (mont29) added a project: BF Blender.May 20 2014, 4:27 PM
Brecht Van Lommel (brecht) removed Brecht Van Lommel (brecht) as the assignee of this task.Oct 5 2015, 2:17 AM
Aaron Carlisle (Blendify) moved this task from Backlog to UI Tweaks on the User Interface board.Sep 4 2016, 10:31 PM
Aaron Carlisle (Blendify) moved this task from UI Tweaks to Keymap/User Preferences on the User Interface board.Sep 4 2016, 10:34 PM
Dalai Felinto (dfelinto) changed the task status from Unknown Status to Unknown Status.Jan 4 2017, 10:25 AM
Dalai Felinto (dfelinto) claimed this task.
Dalai Felinto (dfelinto) added subscribers: Julian Eisel (Severin), Dalai Felinto (dfelinto).

Since this will change for 2.8 (workspaces will have keymaps) I will close/archive this for now.