System Information
Win8 64bit | GTX680
Blender Version
Broken: 2.72 RC eb464ee
Short description of error
In Node Editor, when Shift G and choose "Suffix", Blender crashes.
Exact steps for others to reproduce the error
It's OK to test by using default scene. Thanks for checking.
Bastien, BLI_str_partition_ex_utf8 returns the length of the input string and NULL suffix, this is not properly checked by the callee function. Now, i'm not sure what value that function is expected to return, would think it should return length of the suffix? At leats that's what callee function expects it to be.
Note from my side: I would expect a function like that to always return a valid string if a valid string is passed as input. That means if no delimiter is found it should make sep and suf empty strings (could be simply pointer to str + str_len, i.e. terminator char of the input).
BLI_str_partition_ex_utf8 follows exactly its char counter part BLI_str_partition_ex - we might discuss what's best to do here, but for now issue is in calling code, which is not following BLI's API… will fix.