Page MenuHome
Create Task
Maniphest T41977

Shading panel don't update
Closed, ResolvedPublic
Actions

Description

System Information
windows7 64
ASUS ATI Radeon HD6870

Blender Version
Broken: (All)
Worked: (None)

Short description of error
this bug active for all settings in shading panel of rendering settings lanel
but env map - it is slecial case i was write about this in my report T41976



Exact steps for others to reproduce the error
shading_bump_map_bug.blend2 MBDownload

open, select rendered shading mode, shange anything in shading panel - we will not see update
change anything in 3d view(rot,loc,scale for example) - 3d view will update

Revisions and Commits

rB Blender
rB7493ddc81548 Fix T41977: 'Shading' panel of Render buttons not updating Rendered 3DView.
rBa0b7d24a6f91 Fix T41977: 'Shading' panel of Render buttons not updating Rendered 3DView.

Related Objects

Event Timeline

Alexey (Inwader77) created this task.Sep 27 2014, 5:22 PM
Alexey (Inwader77) raised the priority of this task from to 90.
Alexey (Inwader77) updated the task description. (Show Details)
Alexey (Inwader77) added projects: BF Blender, Render Pipeline.
Alexey (Inwader77) edited a custom field.
Alexey (Inwader77) added a subscriber: Alexey (Inwader77).
Bastien Montagne (mont29) claimed this task.Sep 27 2014, 9:45 PM
Bastien Montagne (mont29) lowered the priority of this task from 90 to Normal.
Bastien Montagne (mont29) merged a task: T41976: env map shading panel bug.
Bastien Montagne (mont29) added a subscriber: Sergey Sharybin (sergey).Sep 27 2014, 10:44 PM

This patch fixes it, but as usual, not sure whether it’s not using a bazooka to kill a fly… :P

P148 (An Untitled Masterwork)
1diff --git a/source/blender/makesrna/intern/rna_scene.c b/source/blender/makesrna/intern/rna_scene.c
2index 682a7f4..9789099 100644
3--- a/source/blender/makesrna/intern/rna_scene.c
4+++ b/source/blender/makesrna/intern/rna_scene.c
5@@ -4547,7 +4547,7 @@ static void rna_def_scene_render_data(BlenderRNA *brna)
6 RNA_def_property_enum_sdna(prop, NULL, "alphamode");
7 RNA_def_property_enum_items(prop, alpha_mode_items);
8 RNA_def_property_ui_text(prop, "Alpha Mode", "Representation of alpha information in the RGBA pixels");
9- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
10+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
11
12 prop = RNA_def_property(srna, "octree_resolution", PROP_ENUM, PROP_NONE);
13 RNA_def_property_enum_sdna(prop, NULL, "ocres");
14@@ -4609,45 +4609,45 @@ static void rna_def_scene_render_data(BlenderRNA *brna)
15 prop = RNA_def_property(srna, "use_shadows", PROP_BOOLEAN, PROP_NONE);
16 RNA_def_property_boolean_sdna(prop, NULL, "mode", R_SHADOW);
17 RNA_def_property_ui_text(prop, "Shadows", "Calculate shadows while rendering");
18- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
19+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
20
21 prop = RNA_def_property(srna, "use_envmaps", PROP_BOOLEAN, PROP_NONE);
22 RNA_def_property_boolean_sdna(prop, NULL, "mode", R_ENVMAP);
23 RNA_def_property_ui_text(prop, "Environment Maps", "Calculate environment maps while rendering");
24- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
25+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
26
27 prop = RNA_def_property(srna, "use_sss", PROP_BOOLEAN, PROP_NONE);
28 RNA_def_property_boolean_sdna(prop, NULL, "mode", R_SSS);
29 RNA_def_property_ui_text(prop, "Subsurface Scattering", "Calculate sub-surface scattering in materials rendering");
30- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
31+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
32
33 prop = RNA_def_property(srna, "use_raytrace", PROP_BOOLEAN, PROP_NONE);
34 RNA_def_property_boolean_sdna(prop, NULL, "mode", R_RAYTRACE);
35 RNA_def_property_ui_text(prop, "Raytracing",
36 "Pre-calculate the raytrace accelerator and render raytracing effects");
37- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
38+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
39
40 prop = RNA_def_property(srna, "use_textures", PROP_BOOLEAN, PROP_NONE);
41 RNA_def_property_boolean_negative_sdna(prop, NULL, "scemode", R_NO_TEX);
42 RNA_def_property_ui_text(prop, "Textures", "Use textures to affect material properties");
43- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
44+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
45
46 prop = RNA_def_property(srna, "use_edge_enhance", PROP_BOOLEAN, PROP_NONE);
47 RNA_def_property_boolean_sdna(prop, NULL, "mode", R_EDGE);
48 RNA_def_property_ui_text(prop, "Edge", "Create a toon outline around the edges of geometry");
49- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
50+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
51
52 prop = RNA_def_property(srna, "edge_threshold", PROP_INT, PROP_NONE);
53 RNA_def_property_int_sdna(prop, NULL, "edgeint");
54 RNA_def_property_range(prop, 0, 255);
55 RNA_def_property_ui_text(prop, "Edge Threshold", "Threshold for drawing outlines on geometry edges");
56- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
57+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
58
59 prop = RNA_def_property(srna, "edge_color", PROP_FLOAT, PROP_COLOR);
60 RNA_def_property_float_sdna(prop, NULL, "edgeR");
61 RNA_def_property_array(prop, 3);
62 RNA_def_property_ui_text(prop, "Edge Color", "Edge color");
63- RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, NULL);
64+ RNA_def_property_update(prop, NC_SCENE | ND_RENDER_OPTIONS, "rna_Scene_glsl_update");
65
66 prop = RNA_def_property(srna, "use_freestyle", PROP_BOOLEAN, PROP_NONE);
67 RNA_def_property_boolean_sdna(prop, NULL, "mode", R_EDGE_FRS);

Alexey (Inwader77) added a comment.Sep 28 2014, 8:28 AM

Will "env map exclude " button working properly?

Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved.Sep 29 2014, 12:53 PM
Bastien Montagne (mont29) added a commit: rBa0b7d24a6f91: Fix T41977: 'Shading' panel of Render buttons not updating Rendered 3DView..

Closed by commit rBa0b7d24a6f91.

Sergey Sharybin (sergey) added a commit: rB7493ddc81548: Fix T41977: 'Shading' panel of Render buttons not updating Rendered 3DView..Oct 3 2014, 3:24 PM