Page MenuHome
Create Task
Maniphest T42205

Changes to the Movie Clip Editor's grid color preferences do not take effect
Closed, ResolvedPublic
Actions

Description

System Information
OS X 10.8.5 ATI Radeon HD 4850 512 MB

Blender Version
Broken: 2.72 95182d1

Short description of error
It appears that the Movie Clip Editor grid color cannot be adjusted. Changing the grid color setting does not have an effect.

Also the Video Sequence Editor and the Node Editor actually lack the option to change the grid color entirely, and while that may be by deliberate design I thought I should bring it up since other editors which have grids do offer that option.

Exact steps for others to reproduce the error

  1. Set part of your workspace to the Movie Clip Editor. Note the grid color.
  2. Open Blender's Preferences and go to the Themes tab.
  3. Navigate to the Movie Clip Editor section and under the Theme clip Editor heading find the color for "Grid".
  4. Change that color value and observe how the grid color in the Movie Clip Editor does not change.

Revisions and Commits

rB Blender
rB8e1ae537dd98 Fix T42205: MovieClip ignores grid color

Related Objects

Event Timeline

Seth L. (quantumanomaly) created this task.Oct 13 2014, 2:45 PM
Seth L. (quantumanomaly) raised the priority of this task from to 90.
Seth L. (quantumanomaly) updated the task description. (Show Details)
Seth L. (quantumanomaly) added a project: BF Blender.
Seth L. (quantumanomaly) edited a custom field.
Seth L. (quantumanomaly) added a subscriber: Seth L. (quantumanomaly).
Campbell Barton (campbellbarton) added subscribers: Sergey Sharybin (sergey), Campbell Barton (campbellbarton).Oct 13 2014, 3:19 PM

Looks like this should simply be removed, its not used anywhere.

@Sergey Sharybin (sergey) ?

diff --git a/source/blender/makesrna/intern/rna_userdef.c b/source/blender/makesrna/intern/rna_userdef.c
index 976a89a..cfeac6a 100644
--- a/source/blender/makesrna/intern/rna_userdef.c
+++ b/source/blender/makesrna/intern/rna_userdef.c
@@ -2784,11 +2784,6 @@ static void rna_def_userdef_theme_space_clip(BlenderRNA *brna)
 	RNA_def_property_ui_text(prop, "Path After", "Color of path after current frame");
 	RNA_def_property_update(prop, 0, "rna_userdef_update");
 
-	prop = RNA_def_property(srna, "grid", PROP_FLOAT, PROP_COLOR_GAMMA);
-	RNA_def_property_array(prop, 3);
-	RNA_def_property_ui_text(prop, "Grid", "");
-	RNA_def_property_update(prop, 0, "rna_userdef_update");
-
 	prop = RNA_def_property(srna, "frame_current", PROP_FLOAT, PROP_COLOR_GAMMA);
 	RNA_def_property_float_sdna(prop, NULL, "cframe");
 	RNA_def_property_array(prop, 3);
Sergey Sharybin (sergey) added a comment.Oct 13 2014, 3:23 PM

Yes, think so. Do you mind comitting?

Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved.Oct 13 2014, 4:28 PM
Campbell Barton (campbellbarton) added a commit: rB8e1ae537dd98: Fix T42205: MovieClip ignores grid color.

Closed by commit rB8e1ae537dd98.