Page MenuHome
Create Task
Maniphest T42506

Infinite Zoom
Closed, ResolvedPublic
Actions

Description

System Information
Windows 8.0 and intel graphics 4600

Blender Version
Broken: 2.72b (9e963ae)
Worked: (optional)

Short description of error
Within the sequencer in preview allows you to zoom forever
creating a very jagged result witch is not needed the super large pixels is more then good

Exact steps for others to reproduce the error

  1. Place a image strip in the sequencer
  2. Go to the preview and zoom in and keep zoom after you get the huge pixels

Revisions and Commits

rB Blender
rB13c275ce8477 Fix T42506 sequencer not limiting zoom.

Related Objects

Event Timeline

Aaron Carlisle (Blendify) created this task.Nov 5 2014, 6:52 PM
Aaron Carlisle (Blendify) raised the priority of this task from to 90.
Aaron Carlisle (Blendify) updated the task description. (Show Details)
Aaron Carlisle (Blendify) added a project: Video Sequencer.
Aaron Carlisle (Blendify) edited a custom field.
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).
Aaron Carlisle (Blendify) awarded a token.Nov 5 2014, 7:10 PM
Aaron Carlisle (Blendify) assigned this task to Jonata Bolzan (jonata).Nov 5 2014, 7:23 PM
Aaron Carlisle (Blendify) removed a subscriber: Aaron Carlisle (Blendify).
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).
Aaron Carlisle (Blendify) rescinded a token.Nov 5 2014, 8:37 PM
Aaron Carlisle (Blendify) added a project: BF Blender.
Aaron Carlisle (Blendify) added a comment.EditedNov 5 2014, 9:03 PM

Here Is a image of what will happen

and you can zoom in more then that

Aaron Carlisle (Blendify) added a project: Images & Movies.Nov 5 2014, 9:07 PM
Aaron Carlisle (Blendify) reassigned this task from Jonata Bolzan (jonata) to Ton Roosendaal (ton).Nov 5 2014, 9:14 PM
Aaron Carlisle (Blendify) reassigned this task from Ton Roosendaal (ton) to Jonata Bolzan (jonata).
Aaron Carlisle (Blendify) added a subscriber: Jonata Bolzan (jonata).
Aaron Carlisle (Blendify) added a subscriber: Ton Roosendaal (ton).
Julian Eisel (Severin) changed the task status from Unknown Status to Archived.Nov 6 2014, 12:46 AM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Hey @Aaron Carlisle (Blendify),
I don't see a need for a fix here. Having no limits isn't a bad thing mostly ;).

Furthermore, I'd like to adress a couple of things in this report:

  • If you don't really know the active Blender developers and who's responsible for which part of Blender, don't assign bugs by yourself. Especially, you shouldn't assign bugs to Ton, as he currently isn't able to code for Blender or fix Bugs at all, there are other people doing this. I'm also not sure why you reassigned it to jonata, who doesn't seem to be an active Developer fixing Bugs (if you've talked to him previously and he offered himself to look into this it's okay, though)
  • You shouldn't add projects on your own (also, as long as you don't really know what you're doing).

Just follow the guide here and let us do the rest. "You do your half of the work, then we do our half!", that's the deal.
That's already it. so, please make sure to don't do the things stated above the next time.

But nevertheless, thanks for the report @Aaron Carlisle (Blendify), but no real bug here :)

Jonata Bolzan (jonata) added a comment.Nov 6 2014, 1:25 AM

Hello. I am not an active developer, I am just a user who sends bugs and bothers the developers a bit :D

Aaron Carlisle (Blendify) added a comment.Nov 6 2014, 4:10 AM

hey sorry this is my first bug report
a couple of things one the bug
it only happened in the sequencer, not in the image editor, and you can zoom in for hour then spend the same time amount of time undoing it. i did not confirm this however it will turn to the color of the background.

Aaron Carlisle (Blendify) changed the task status from Archived to Unknown Status.Nov 6 2014, 4:10 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).EditedNov 6 2014, 9:32 AM

Note: seems that sequencer limits aren't enforced:

This change however only applies to newly created spaces, needs a do-versions too to update existing files.

P159 possible fix for T42506
1diff --git a/source/blender/editors/space_sequencer/space_sequencer.c b/source/blender/editors/space_sequencer/space_sequencer.c
2index c0cfaed..f97344f 100644
3--- a/source/blender/editors/space_sequencer/space_sequencer.c
4+++ b/source/blender/editors/space_sequencer/space_sequencer.c
5@@ -144,7 +144,7 @@ static SpaceLink *sequencer_new(const bContext *C)
6 ar->alignment = RGN_ALIGN_TOP;
7 ar->flag |= RGN_FLAG_HIDDEN;
8 /* for now, aspect ratio should be maintained, and zoom is clamped within sane default limits */
9- ar->v2d.keepzoom = V2D_KEEPASPECT | V2D_KEEPZOOM;
10+ ar->v2d.keepzoom = V2D_KEEPASPECT | V2D_KEEPZOOM | V2D_LIMITZOOM;
11 ar->v2d.minzoom = 0.00001f;
12 ar->v2d.maxzoom = 100000.0f;
13 ar->v2d.tot.xmin = -960.0f; /* 1920 width centered */

Julian Eisel (Severin) claimed this task.Nov 6 2014, 10:04 AM

Okay, should be an easy fix. Can have a look at it later.

Campbell Barton (campbellbarton) added a comment.Nov 6 2014, 11:36 AM

This could be set as todo, its not really much of a problem

be sure to check this fix works for split-screen preview too.

Julian Eisel (Severin) lowered the priority of this task from 90 to Normal.Nov 6 2014, 11:57 AM
Aaron Carlisle (Blendify) added a comment.Nov 6 2014, 8:52 PM

I don't no exactly how this "bit" of code works but make sure that it will apply itself to the other previews such as the Vetro-Scope waveform and histogram.

Campbell Barton (campbellbarton) triaged this task as 50 priority.Nov 10 2014, 5:30 PM
Campbell Barton (campbellbarton) edited a custom field.

Setting as todo, this isn't really preventing anyone from using the zoom operator.

Aaron Carlisle (Blendify) added a project: Good First Issue.Nov 11 2014, 2:15 AM
Julian Eisel (Severin) removed Julian Eisel (Severin) as the assignee of this task.Nov 11 2014, 11:32 PM
Campbell Barton (campbellbarton) added a comment.Nov 14 2014, 2:26 PM

Don't think this is a quick hack, its a very small change but needs to be done carefully and test with file versioning.

Campbell Barton (campbellbarton) removed projects: Good First Issue, Images & Movies.Nov 14 2014, 2:26 PM
Campbell Barton (campbellbarton) removed a subscriber: Ton Roosendaal (ton).
Aaron Carlisle (Blendify) assigned this task to Antonis Ryakiotakis (psy-fi).Feb 6 2015, 5:23 PM

May be gooseberry can fix this

Antonis Ryakiotakis (psy-fi) changed the task status from Unknown Status to Resolved.Feb 26 2015, 2:28 PM
Antonis Ryakiotakis (psy-fi) added a commit: rB13c275ce8477: Fix T42506 sequencer not limiting zoom..

Closed by commit rB13c275ce8477.

Aaron Carlisle (Blendify) changed the task status from Resolved to Unknown Status.Mar 4 2015, 8:16 PM

This is fixed 25%

see picture

(Nota Bene: This Picture is of two pixels next to each other zoomed to really far)

The zoom limits should be somewhere like that of the image editor

Antonis Ryakiotakis (psy-fi) changed the task status from Unknown Status to Resolved.Mar 5 2015, 7:06 PM

Limits should be more sane now.

Aaron Carlisle (Blendify) changed the task status from Resolved to Unknown Status.Mar 10 2015, 9:20 PM

still does not work?

Linux build afa8a0a

Antonis Ryakiotakis (psy-fi) changed the task status from Unknown Status to Resolved.Mar 10 2015, 10:31 PM

It "works" fine, it is not really important does not stop anyone from working and we have much more important things to look at.

Aaron Carlisle (Blendify) added a comment.Mar 11 2015, 6:59 PM

is it a reasonable option to keep this as a todo since pixels start to look like multiple pixels

Campbell Barton (campbellbarton) edited a custom field.Mar 12 2015, 12:44 PM