Page MenuHome
Create Task
Maniphest T42754

UI Bug with Full Window mode
Closed, ResolvedPublic
Actions

Description

System Information
Windows 8.0 Intel HD Graphics 4600

Blender Version
Broken: 2.72b, 9e963ae
Worked: 2.49

Short description of error
When exiting full screen mode it changes the window from file browser to what ever it was before.
Exact steps for others to reproduce the error

  1. Open the default blender scene
  2. Take the 3d view port and turn it into a split screen.
  3. Change that split screen into the file browser
  4. Go into full screen mode (CTRL + Up Arrow)
  5. Then use the return to previous button (using the key board short cut works fine.
  6. The window will change back to the 3d view port

Revisions and Commits

rB Blender
rBc6d28a94bee2 Fix T42754: File-Selector lost on fullscreen exit

Related Objects

Event Timeline

Aaron Carlisle (Blendify) created this task.Nov 29 2014, 3:32 AM
Aaron Carlisle (Blendify) raised the priority of this task from to 90.
Aaron Carlisle (Blendify) updated the task description. (Show Details)
Aaron Carlisle (Blendify) added projects: BF Blender, User Interface.
Aaron Carlisle (Blendify) edited a custom field.
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).
Bastien Montagne (mont29) assigned this task to Dalai Felinto (dfelinto).Nov 29 2014, 7:51 AM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Dalai, think this one is for you?

Bastien Montagne (mont29) lowered the priority of this task from 90 to 50.Nov 29 2014, 7:51 AM
Aaron Carlisle (Blendify) added a comment.Nov 29 2014, 11:20 PM

I think what happened here is. Many times blender will open a file browser in full screen when selecting something such as a texture then returns to the previous ui which is different then from the users choice.

Dalai Felinto (dfelinto) added a comment.Dec 2 2014, 12:36 PM

This is prior to the fullscreen changes introduced in 7c25f16f (2.73). In fact the behaviour we have is different when you toggle fullscreen ('SCREEN_OT_screen_full_area') or you run 'SCREEN_OT_back_to_previous'.

Dalai Felinto (dfelinto) removed Dalai Felinto (dfelinto) as the assignee of this task.Dec 2 2014, 7:18 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

To solve the bug as reported, all you need is this patch: P168

That said, this still doesn't solve another issue of having the 'file browser' editor being set to its previous type when you invoke an operator that requires file browser (e.g., with the mouse over the file browser editor press F2 to save the file and press cancel).

This is a bug that always existed in Blender I believe. I won't have the time to look at that any soon.

Aaron Carlisle (Blendify) added a comment.Dec 5 2014, 3:19 PM

What needs to happen is that Blender needs to know if the ui changes was made by blender or the user.

So if blender is defining the ui change the fallow this code
if it is defined the user the fallow this code

Aaron Carlisle (Blendify) claimed this task.Dec 5 2014, 4:06 PM
Aaron Carlisle (Blendify) renamed this task from UI Bug with full coming back from full screen mode to UI Bug with Full Window mode.Dec 5 2014, 4:10 PM
Aaron Carlisle (Blendify) removed Aaron Carlisle (Blendify) as the assignee of this task.
Aaron Carlisle (Blendify) updated the task description. (Show Details)
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).Dec 8 2014, 3:47 PM

@Dalai Felinto (dfelinto), why don't we commit your patch, as it fixes the bug here and handle the rest as ToDo? I don't think we need bug reports for behaviours that are missing since ages

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Dec 22 2014, 10:20 AM

@Julian Eisel (Severin), before proposing to accept the patch it's nice to test it first. It is just broken. Try pressing F1 and then "Back to previous".

And i don't really think it is such a bug, just known behavior, so unless you want to look into a proper solution to the TODO list it should go.

Aaron Carlisle (Blendify) mentioned this in T37982: File Browser options minor UI improvements.Dec 22 2014, 11:16 PM
Aaron Carlisle (Blendify) added a subscriber: Scott Petrovic (scottpetrovic).
Aaron Carlisle (Blendify) mentioned this in T43008: Stacked Full Window Mode.Dec 24 2014, 9:41 PM
Sergey Sharybin (sergey) merged a task: T43008: Stacked Full Window Mode.Dec 24 2014, 11:27 PM
Aaron Carlisle (Blendify) added a comment.Dec 25 2014, 6:27 PM

These are two differant bugs the first one is specific to the file browser the other is from a full window on a full window mode

Campbell Barton (campbellbarton) changed the task status from Unknown Status to Resolved.Jan 12 2015, 3:47 PM
Campbell Barton (campbellbarton) added a commit: rBc6d28a94bee2: Fix T42754: File-Selector lost on fullscreen exit.

Closed by commit rBc6d28a94bee2.